-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39212: [Release] Retry download binary subprocess in case of OpenSSL error #39213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want (exponential) delay in between attempts?
I've added something, let me know if something like that is what you had in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…cations Co-authored-by: Sutou Kouhei <[email protected]>
@kou I haven't seen those errors in a while but this might be worth merging. I realized there was a lint failure once the review comments were merged and this is probably why it got stale. I've fixed it and validated locally it works correctly. |
Let's merge this. |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b655852. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
In case of OpenSSL error when trying to download RC binaries we do not retry and we are facing some issues with artifactory that after some job retries allowed us to successfully download the binaries.
What changes are included in this PR?
Retry mechanism in case of subprocess error.
Are these changes tested?
Tested locally verifying wheels and jars for 14.0.2 RC 3.
Are there any user-facing changes?
No