Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39212: [Release] Retry download binary subprocess in case of OpenSSL error #39213

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 13, 2023

Rationale for this change

In case of OpenSSL error when trying to download RC binaries we do not retry and we are facing some issues with artifactory that after some job retries allowed us to successfully download the binaries.

What changes are included in this PR?

Retry mechanism in case of subprocess error.

Are these changes tested?

Tested locally verifying wheels and jars for 14.0.2 RC 3.

Are there any user-facing changes?

No

@raulcd raulcd requested review from lidavidm and kou and removed request for kou and assignUser December 13, 2023 11:49
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 13, 2023
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want (exponential) delay in between attempts?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Dec 13, 2023
@raulcd
Copy link
Member Author

raulcd commented Dec 13, 2023

We might want (exponential) delay in between attempts?

I've added something, let me know if something like that is what you had in mind.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

dev/release/download_rc_binaries.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Dec 13, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 14, 2023
@raulcd
Copy link
Member Author

raulcd commented Dec 18, 2024

@kou I haven't seen those errors in a while but this might be worth merging. I realized there was a lint failure once the review comments were merged and this is probably why it got stale. I've fixed it and validated locally it works correctly.
Feel free to close or merge :)

@kou
Copy link
Member

kou commented Dec 18, 2024

Let's merge this.

@kou kou merged commit b655852 into apache:main Dec 18, 2024
5 checks passed
@kou kou removed the awaiting change review Awaiting change review label Dec 18, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b655852.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release] Add retry mechanism in case of failure downloading RC binaries
3 participants