-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents #39151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We will implement this when we add allow_container_deletion
#38999, right?
(Or we may add one more option only for this something like allow_all_containers_deletion
?)
Personally I think it's reasonable to never implement this. |
s3fs doesn't infer that it's OK to delete all the buckets from these options and doesn't have an option allowing deleting everything. I think anyone that wants to delete all containers will either do it manually or via the official SDK if the want to do it programmatically. |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 47f4d18. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
apache#39151) ### Rationale for this change This copies the behavior implemented by S3FileSystem. ### What changes are included in this PR? An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers. ### Are these changes tested? N/A. * Closes: apache#38702 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
apache#39151) ### Rationale for this change This copies the behavior implemented by S3FileSystem. ### What changes are included in this PR? An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers. ### Are these changes tested? N/A. * Closes: apache#38702 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
apache#39151) ### Rationale for this change This copies the behavior implemented by S3FileSystem. ### What changes are included in this PR? An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers. ### Are these changes tested? N/A. * Closes: apache#38702 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Rationale for this change
This copies the behavior implemented by S3FileSystem.
What changes are included in this PR?
An implementation of
DeleteRootDirContent
that prevents deletion of all blob containers.Are these changes tested?
N/A.
DeleteRootDirContents()
#38702