GH-39159 [C++]: Try to make Buffer::device_type_ non-optional #39150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pitrou if you're OK with the type change I will create an issue for this PR. |
pitrou
reviewed
Dec 8, 2023
cpp/src/arrow/buffer.h
Outdated
| @@ -296,6 +296,7 @@ class ARROW_EXPORT Buffer { | |||
|
|
|||
| const std::shared_ptr<MemoryManager>& memory_manager() const { return memory_manager_; } | |||
|
|
|||
| /// XXX(felipecrv): can we change the return type to remove the optional? | |||
github-actions
bot
added
awaiting committer review
felipecrv
changed the title
|
|
felipecrv
force-pushed
the
require_device_type
branch
from
ef3ccf3 to
a43895d
Compare
pitrou
approved these changes
Dec 11, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 595b37c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Buffer should always have a device type. When unspecified, CPU can be assumed.
What changes are included in this PR?
A change of the member variable type and some adjustments.
Are these changes tested?
N/A.
Are there any user-facing changes?
This PR includes breaking changes to public APIs.
Buffer::device_type_is now aDeviceAllocationTypeinstead of astd::optional<DeviceAllocationType>.