Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes me wonder if build_to_thrift should return an Option, to make sure callers don't forget to check .valid(). #6064

Open
alamb opened this issue Jul 15, 2024 · 0 comments

Comments

@alamb
Copy link
Contributor

alamb commented Jul 15, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

@progval pointed out that the current API for building ColumnIndex requires users to remember to call valid()

          Makes me wonder if `build_to_thrift` should return an `Option`, to make sure callers don't forget to check `.valid()`.

Originally posted by @progval in #6042 (comment)

Describe the solution you'd like
Change ColumnIndexBuilder::build_to_thrift so it returns Option - specifically None if valid() is false

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant