We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_to_thrift
Option
.valid()
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
@progval pointed out that the current API for building ColumnIndex requires users to remember to call valid()
ColumnIndex
valid()
Makes me wonder if `build_to_thrift` should return an `Option`, to make sure callers don't forget to check `.valid()`.
Originally posted by @progval in #6042 (comment)
Describe the solution you'd like Change ColumnIndexBuilder::build_to_thrift so it returns Option - specifically None if valid() is false
ColumnIndexBuilder::build_to_thrift
None
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
@progval pointed out that the current API for building
ColumnIndex
requires users to remember to callvalid()
Originally posted by @progval in #6042 (comment)
Describe the solution you'd like
Change
ColumnIndexBuilder::build_to_thrift
so it returnsOption
- specificallyNone
ifvalid()
is falseDescribe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: