Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add PR title format checker #487

Open
lidavidm opened this issue Jan 7, 2025 · 2 comments
Open

[CI] Add PR title format checker #487

lidavidm opened this issue Jan 7, 2025 · 2 comments
Labels
Type: enhancement New feature or request

Comments

@lidavidm
Copy link
Member

lidavidm commented Jan 7, 2025

Describe the enhancement requested

  • Either MINOR: or GH-NNN.
  • If GH-NNN, check for closing keywords in body and if not present, add them.
  • We can validate components too?
@lidavidm lidavidm added the Type: enhancement New feature or request label Jan 7, 2025
@lidavidm lidavidm changed the title [CI] Add PR format checker [CI] Add PR title format checker Jan 7, 2025
@CalvinKirs
Copy link
Member

Hi David,
2: Parsing the pr.body can be costly and may have a slightly higher chance of errors, so I’m leaning towards using the GitHub API approach (i.e., using a script to call the relevant API and reading the closingIssuesReferences field). What do you think?

3: Could you provide more details on this?

@lidavidm
Copy link
Member Author

(2): sounds good to me.

(3): We had a convention of writing titles like GH-123: [Release] Update release scripts. Maybe we can parse the [Release] part and validate that it's one of the expected components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants