ListViewVector#getElementEndIndex Returns Size not Index

[nbauernfeind]

This method is incorrectly implemented:

  @Override
  public int getElementEndIndex(int index) {
    return sizeBuffer.getInt(index * OFFSET_WIDTH);
  }

https://github.com/apache/arrow-java/blob/main/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java#L957-L960

The javadoc indicates this is an offset not a length:

  /** Get data vector end index with the given list index. */
  int getElementEndIndex(int index);

This issue exists in main as of 480e1be.

[vibhatha]

@nbauernfeind thanks for filing this issue. Would you like to make a PR?

[joyCurry30]

Can you assign to me ? I'd like to make a PR.

[kou]

Done!

[PURVANGIKA]

public int getElementEndIndex(int index) {
// Retrieve the offset from the offset buffer instead of sizeBuffer
return offsetBuffer.getInt((index + 1) * OFFSET_WIDTH);
}