Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamController are not closed. #59

Open
jodinathan opened this issue Nov 13, 2021 · 0 comments
Open

StreamController are not closed. #59

jodinathan opened this issue Nov 13, 2021 · 0 comments

Comments

@jodinathan
Copy link
Collaborator

While digging through the code I have noticed that the StreamController are not closed.

Ie date_input.dart:

final _controller = StreamController<Date?>.broadcast();

Shouldn't we close it within ngOnDestroy to not have a memory leak?

I guess it would be better if we attach it into Disposer and let it clear the stuff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jodinathan