Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from decimal import Decimal never suggested for Decimal #20

Open
glyph opened this issue Sep 29, 2020 · 3 comments
Open

from decimal import Decimal never suggested for Decimal #20

glyph opened this issue Sep 29, 2020 · 3 comments
Labels

Comments

@glyph
Copy link

glyph commented Sep 29, 2020

I assume this is because it's a C module and therefore there's no source to scan. I'm opening this on .el rather than the Python library because the Python library has a way to add import statements but it's not clear to me what the "right" way to inject those into the relevant process is.

@ryanprior
Copy link

Hello @glyph thank you for your report! 🚨

I just reproduced this and will look into it more. Are you interested in contributing a fix?

@ryanprior ryanprior added the bug label Sep 30, 2020
@glyph
Copy link
Author

glyph commented Sep 30, 2020

I am fairly full up on work right now, sorry to say! And I don't have a lot of experience contributing to elisp projects, despite having written embarrassing amounts of elisp code in my life. If I did have time, do you have a guide for how to install importmagic.el from a git checkout and how to run tests or otherwise set up one's environment to contribute?

@ryanprior
Copy link

I understand time is scarce. If you do find time and motivation, it would be wonderful to have your contribution!

There is a tiny guide here: https://github.com/anachronic/importmagic.el#contributing
I would do well to expand on it some. To answer your questions specifically:

To install importmagic.el from a git checkout, you load importmagic.el into your Emacs and then M-x eval-buffer. There are fancier methods: straight.el explicitly supports this use case for example. But there's little drawback to doing it the simple way.

To run the tests, you execute cask exec ert-runner in the project's root directory. There are unit tests in test/ and behavior tests in features/. Cask helps set up your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants