Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

db-cli-reportrunner broken #75

Closed
hyandell opened this issue Sep 16, 2016 · 2 comments
Closed

db-cli-reportrunner broken #75

hyandell opened this issue Sep 16, 2016 · 2 comments
Labels

Comments

@hyandell
Copy link
Contributor

The CLI method for running db reports (useful for testing) is broken as it didn't change when the db-report API changed to include context.

It needs to build up a new context and pass that along, which might mean simplifying its command line args to have the overall conf file passed in and the report to run. That might mean duplicating some code from elsewhere, so refactoring could be useful (like a separate Context file).

@hyandell hyandell added the bug label Sep 16, 2016
@hyandell
Copy link
Contributor Author

Noting that I've updated it so it doesn't break. ie) it passes an empty context right now. If the report depends on the context, it will then break.

@jamesiri
Copy link
Contributor

jamesiri commented May 4, 2021

#142

@jamesiri jamesiri closed this as completed May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants