-
Notifications
You must be signed in to change notification settings - Fork 40
Pluggable charts #18
Comments
Thinking out loud; charts have two aspects to them:
With flot you can comfortably have two separate JSON files be used; though it wasn't the simplest with some of my charts because it doesn't like having years missing (i.e. it doesn't know they're years). The data had to be munged if zero data was going to show up to ensure the zero data was there. |
A third aspect may be placement. The change to the UI means that a Charts menu will automatically be available, but I'll also want to use the framework for the current hardcoded charts. I'll still want to place them at the top of standard pages, and there should be a mechanism to replace them with other charts. Alternatively rather than placement, the hardcoded charts could have ids. When the configuration is loaded, it is put over the top of a default list of charts, replacing any that have the same id. The ids then serve as placement. There will also need to be user, issue and repository charts, just as there is that separation of types for reports. One possibility is to just have it use the reports framework, but add charts as a particular configuration of rendering. The existing reports perhaps would be a table rendering, allowing for other forms besides charts and tables. Possibly a bit of an over-design given the simplicity of architecture of the rest of the system :) Which may speak to a port from XSLT to ERB or some such :) |
Noting that I'm working on this at the moment. JSON data files are pulled, along with JSON chart configuration. This'll make it possible for reports to provide data/chart json to indicate they have a chart or more to include in their report. |
The above change is now committed. |
Currently charts are hard coded. The data should be moved out to JSON files rather than inline, and there should be a way to add your own charts.
The text was updated successfully, but these errors were encountered: