Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

user-repositories break assumptions at multiple places #115

Closed
soumith opened this issue Nov 6, 2017 · 3 comments
Closed

user-repositories break assumptions at multiple places #115

soumith opened this issue Nov 6, 2017 · 3 comments
Labels

Comments

@soumith
Copy link

soumith commented Nov 6, 2017

if one is tracking user-repositories (i.e. not under an org), for example: ry/v8worker, then many parts of the code break.

The code eventually goes into an infinite loop of API accesses like this:
ry GitHub client error, pushing command back on queue: GET https://api.github.com/orgs/ry/repos?per_page=100: 404 - Not Found // See: https://developer.github.com/v3/repos/#list-organization-repositories

@hyandell
Copy link
Contributor

hyandell commented Nov 7, 2017

It currently only supports org/repos, org and user (ie: no user-repos).

https://github.com/amzn/oss-dashboard/blob/master/dashboard-context.rb needs to be improved so that repositories() is able to include user repos. Hopefully fixing just that would cascade along.

@hyandell hyandell added the bug label Dec 24, 2017
@hyandell
Copy link
Contributor

I think there are two ways to solve it.

A) Change the code so that it's able to tell if 'xyzzy' is a login or an organization.
B) Add a login-repositories: configuration option.

The problem with A is that it requires a call to GitHub, and that I don't think there is an ideal query so it's relying on a side-effect (for example trying to get organization repositories and seeing it error).

So I'm leaning to B).

@jamesiri
Copy link
Contributor

jamesiri commented May 4, 2021

#142

@jamesiri jamesiri closed this as completed May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants