Skip to content

Latest commit

 

History

History
85 lines (65 loc) · 5.54 KB

CONTRIBUTING.md

File metadata and controls

85 lines (65 loc) · 5.54 KB

Contributing to Featuretools-SQL

👍🎉 First off, thank you for taking the time to contribute! 🎉👍

Whether you are a novice or experienced software developer, all contributions and suggestions are welcome!

There are many ways to contribute to Featuretools-SQL, with the most common ones being contribution of code.

To contribute, you can:

  1. Help users on our Slack channel. Answer questions under the featuretools tag on Stack Overflow

  2. Submit a pull request for one of Good First Issues

  3. Make changes to the codebase, see Contributing to the codebase.

  4. Report issues you're facing, and give a "thumbs up" on issues that others reported and that are relevant to you. Issues should be used for bugs, and feature requests only.

  5. Spread the word: reference Featuretools from your blog and articles, link to it from your website, or simply star it in GitHub to say "I use it".

Contributing to the Codebase

Before starting major work, you should touch base with the maintainers of Featuretools-SQL by filing an issue on GitHub or posting a message in the #development channel on Slack. This will increase the likelihood your pull request will eventually get merged in.

1. Fork and clone repo

  • The code is hosted on GitHub, so you will need to use Git to fork the project and make changes to the codebase. To start, go to the Featuretools GitHub page and click the Fork button.
  • After you have created the fork, you will want to clone the fork to your machine and connect your version of the project to the upstream Featuretools repo. 
    git clone https://github.com/your-user-name/featuretools_sql.git
cd featuretools_sql
git remote add upstream https://github.com/alteryx/featuretools_sql
  • Once you have obtained a copy of the code, you should create a development environment that is separate from your existing Python environment so that you can make and test changes without compromising your own work environment. You can run the following steps to create a separate virtual environment, and install Featuretools in editable mode. 
    python -m venv venv
source venv/bin/activate
make installdeps-dev
git checkout -b issue####-branch_name

2. Implement your Pull Request

  • Implement your pull request. If needed, add new tests.
  • Before submitting to GitHub, verify the tests run and the code lints properly 
    # runs linting
make lint

# will fix some common linting issues automatically
make lint-fix

# runs test
make test
  • Before you commit, a few lint fixing hooks will run. You can also manually run these. 
    # run linting hooks only on changed files
pre-commit run

# run linting hooks on all files
pre-commit run --all-files

3. Submit your Pull Request

  • Once your changes are ready to be submitted, make sure to push your changes to GitHub before creating a pull request.

  • If you need to update your code with the latest changes from the main Featuretools-SQL repo, you can do that by running the commands below, which will merge the latest changes from the Featuretools-SQL main branch into your current local branch. You may need to resolve merge conflicts if there are conflicts between your changes and the upstream changes. After the merge, you will need to push the updates to your forked repo after running these commands.

    git fetch upstream
git merge upstream/main

  • Create a pull request to merge the changes from your forked repo branch into the Featuretools-SQL main branch. Creating the pull request will automatically run our continuous integration.

  • If this is your first contribution, you will need to sign the Contributor License Agreement as directed.

  • Update the "Future Release" section of the release notes (docs/release_notes.rst) to include your pull request and add your github username to the list of contributors. Add a description of your PR to the subsection that most closely matches your contribution:

    • Enhancements: new features or additions to Featuretools-SQL.
    • Fixes: things like bugfixes or adding more descriptive error messages.
    • Changes: modifications to an existing part of Featuretools-SQL.
    • Documentation Changes
    • Testing Changes

    Documentation or testing changes rarely warrant an individual release notes entry; the PR number can be added to their respective "Miscellaneous changes" entries.

  • We will review your changes, and you will most likely be asked to make additional changes before it is finally ready to merge. However, once it's reviewed by a maintainer of Featuretools-SQL, passes continuous integration, we will merge it, and you will have successfully contributed to Featuretools-SQL!

Report issues

When reporting issues please include as much detail as possible about your operating system, Featuretools-SQL version and python version. Whenever possible, please also include a brief, self-contained code example that demonstrates the problem.