New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring idea: Run method #63

Open

ccoVeille opened this issue Dec 22, 2024 · 0 comments

Labels

enhancement help wanted

Collaborator

ccoVeille commented Dec 22, 2024

Run method use channels for errors and outputs, but also use a fmt.Fprintf(os.Stderr

We could check what could be done to simplify things. Ideas such as:

check of the method signature shouldn't be updated to return an error. Handling error with printing is strange to me,it should be moved to higher level.
check if other errors currently send to outputCh or errCh shouldn't also be refactored

Originally posted by @ccoVeille in #60 (comment)

alegrey91 added enhancement help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment