You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IdConverter takes a size argument, but since the id converter doesn't restrict the alphabet, cannot size be automatically determined from the size of T?
If IdConverter is restricted to take a character T and Character is expanded to take num_traits::Bounded we could use T::max_value(), I think.
Since FmIndex already is restricted by Character I think it's fine to restrict IdConverter with it too (it isn't currently).
I don't think it's likely people will implement their own implementation of the Character trait that isn't bounded, right? (or at all)
The text was updated successfully, but these errors were encountered:
IdConverter
takes asize
argument, but since the id converter doesn't restrict the alphabet, cannot size be automatically determined from the size ofT
?If
IdConverter
is restricted to take a characterT
andCharacter
is expanded to takenum_traits::Bounded
we could useT::max_value()
, I think.Since
FmIndex
already is restricted byCharacter
I think it's fine to restrictIdConverter
with it too (it isn't currently).I don't think it's likely people will implement their own implementation of the
Character
trait that isn't bounded, right? (or at all)The text was updated successfully, but these errors were encountered: