-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with STUN for consent refresh (RFC7675) #58
Comments
I'm not sure we should be doing retransmissions here, wouldn't this throw off the frequency of these requests? It seems odd to me that you're getting 6 consecutive fails? |
I faced the same issue ( consent to send refresh) when I tried having multiple threads running together into the same process. I can provide more info regarding that but it's not an aioice issue. It mainly relies on the software architecture of your project. |
In the light of @mariokrous's feedback I'm tmpted to close this issue. |
@mariokrous |
In my setup I have a WebRTC data channel that I use to transfer relatively big data packages of ~30 MB. I observed connection closings when running the code on my embedded system (Jetson Nano). I investigated the errors and noticed that this line here is hit:
aioice/src/aioice/ice.py
Line 951 in c71c3af
Root cause of that were 6 TransactionTimeouts: https://github.com/aiortc/aioice/blob/main/src/aioice/stun.py#L306 that were accumulated during the entire transfer.
I actually don't know why those timeouts happen (it is reproducible). But upon further digging into the code I notice that no retransmissions are done upon a failure: https://github.com/aiortc/aioice/blob/main/src/aioice/ice.py#L965
I would suggest to increase the retransmissions to at least 1. Or is there a particular reason for setting it to 0?
If anybody would have ideas for the root cause of my TransactionTimeouts it would be very welcome. Could a high system load (sending the data over the datachannel) lead to timeouts because the system misses to answer the Consent checks in time?
If it is of any help: I have wireshark traces of the STUN packages.
The text was updated successfully, but these errors were encountered: