-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution page layout #35
Comments
Nope, they're different. The attribute is "transfer frequency" which is a "time duration" object type. Just as the Online Resource "Name", "Protocol" and "Description" attributes are all of type "string". |
Second UpdateHere is a screenshot of the Distribution section. I removed the Online Transfer and Time Duration Object items from the bottom and made them their own page. The links in-page work when tested on my localhost server as well. Here you can see the side navigation for those new areas. Here you can see the Online Transfer section. This is the Transfer Frequency page. Please advise on the details of these items to help refine the tone or proper wording. |
Pull Request ReviewBefore submitting a pull request, I wanted to submit some of the changes I have made on the dev branch of my fork. Changed the "Summary.md" file to show the new page navigation options These options are "Online Transfer Option" and "Transfer Frequency". I created a page for Transfer Frequency. I used the same name for the file that The path for this file is here: The page for the "Online Transfer Option" is found here: Edited the "Transfer Option" page located here: For that page, I removed the “Online Option” and “Time Duration” sections that were Updated the "Online Transfer Option" screenshot. It is located here: |
This looks fine. Are you using the https://github.com/adiwg/mdEditor-doc/blob/master/reference/include-objects? |
I corrected the use of include-objects and also made sure the links in the Distribution section were working as well. EDIT: After running the build again, I noticed I cannot click on the link to open the correct page. It seems to know where to go as it will open in another window or allow me to save the markdown file. However, it will not open on click as with "offlineTransferOption". I am working to see what caused this issue. |
Update 3 I worked to correct the navigation issues found in the Distribution section of the Summary.md file. I replaced these with the following: [Online Transfer Option](reference/edit-window/metadata/distribution-panels/ onlineTransferOption.md) I tested these items locally and found them to be working as intended. This is noted in the rolling doc changes as well. |
This issue has a few components to address.
Taking a look at the following section of the guide first.
When looking at the left-hand navigation options for the guide, you will see the following structure.
Currently, there is an Online Transfer option that is not listed in that set above. It should go above the Offline Transfer option.
As for the Online Transfer section, Here is the screenshot as it appears in the guide currently:
Here is how it appears in the current mdEditor version:
I noticed that there are two parts that are different, those at the end.
• Application Profile
• Protocol Request
These would need to be added to the Online Transfer page with relevant information.
Application Profile seems to just be the name of the API itself being used.
Protocol Request seems in turn to just be the request time being made to the API, (POST, GET, PUT, or possibly even DELETE).
Please provide any input you may have on this topic.
The text was updated successfully, but these errors were encountered: