Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution page layout #35

Open
IronRico opened this issue Jun 17, 2020 · 8 comments
Open

Distribution page layout #35

IronRico opened this issue Jun 17, 2020 · 8 comments
Assignees
Labels
documentation Deals with documentation updates

Comments

@IronRico
Copy link
Contributor

This issue has a few components to address.

Taking a look at the following section of the guide first.

When looking at the left-hand navigation options for the guide, you will see the following structure.

Ashampoo_Snap_Wednesday, June 17, 2020_10h46m49s_002_

Currently, there is an Online Transfer option that is not listed in that set above. It should go above the Offline Transfer option.

  • Distribution Section
    • Distribution Edit Window
    • Distributor Edit Window
      • Transfer Option
        • Online Transfer
        • Offline Transfer
        • Distribution Format
  • Order Process

As for the Online Transfer section, Here is the screenshot as it appears in the guide currently:

image

Here is how it appears in the current mdEditor version:

image


I noticed that there are two parts that are different, those at the end.
Application Profile
Protocol Request

These would need to be added to the Online Transfer page with relevant information.

Application Profile seems to just be the name of the API itself being used.
Protocol Request seems in turn to just be the request time being made to the API, (POST, GET, PUT, or possibly even DELETE).


Please provide any input you may have on this topic.

@IronRico IronRico added the documentation Deals with documentation updates label Jun 17, 2020
@IronRico
Copy link
Contributor Author

IronRico commented Jun 20, 2020

I have not requested a pull request on this, however, I did do some mock-up work in my own repo to see how this would look.

Here is a screenshot of the Online Transfer option page.

Ashampoo_Snap_Friday, June 19, 2020_21h16m54s_001_

I would like input on the details of the bullet items, as to what proper wording would be wanted, ( or unwanted).


I also tested linking the page in the sidebar by editing the Summary.md file. When I ran locally on my machine, it seemed to work without issue.

Ashampoo_Snap_Friday, June 19, 2020_21h17m40s_002_


Please advise if this would have any negative issues using this method.

@IronRico
Copy link
Contributor Author

"Time Duration Object" or "Transfer Frequency"?

On the Distribution page, I noted that there are these two sections that I assume are one in the same with different names. I added screenshots below.

Ashampoo_Snap_Monday, June 22, 2020_17h06m16s_001_

Ashampoo_Snap_Monday, June 22, 2020_17h06m44s_002_


Are these indeed the same item only with different names, or are these totally separate?

@hmaier-fws
Copy link
Contributor

Nope, they're different. The attribute is "transfer frequency" which is a "time duration" object type. Just as the Online Resource "Name", "Protocol" and "Description" attributes are all of type "string".

@IronRico
Copy link
Contributor Author

Second Update

Here is a screenshot of the Distribution section. I removed the Online Transfer and Time Duration Object items from the bottom and made them their own page. The links in-page work when tested on my localhost server as well.

Ashampoo_Snap_Tuesday, June 23, 2020_18h28m49s_003_


Here you can see the side navigation for those new areas.

Ashampoo_Snap_Tuesday, June 23, 2020_18h28m06s_002_


Here you can see the Online Transfer section.

Ashampoo_Snap_Tuesday, June 23, 2020_18h29m28s_004_


This is the Transfer Frequency page.

Ashampoo_Snap_Tuesday, June 23, 2020_18h27m41s_001_


Please advise on the details of these items to help refine the tone or proper wording.

@IronRico
Copy link
Contributor Author

Pull Request Review

Before submitting a pull request, I wanted to submit some of the changes I have made on the dev branch of my fork.


Changed the "Summary.md" file to show the new page navigation options
under "Transfer Option".

These options are "Online Transfer Option" and "Transfer Frequency".

I created a page for Transfer Frequency. I used the same name for the file that
was already in use, ("timeDuration-obj").

The path for this file is here:
mdEditor-doc/reference/edit-window/metadata/distribution-panels/timeDuration-obj.md

The page for the "Online Transfer Option" is found here:
mdEditor-doc/reference/edit-window/metadata/distribution-panels/onlineTransferOption.md

Edited the "Transfer Option" page located here:
mdEditor-doc/reference/edit-window/metadata/distribution-panels/transferOption.md

For that page, I removed the “Online Option” and “Time Duration” sections that were
found at the bottom.

Updated the "Online Transfer Option" screenshot. It is located here:
assets/reference/edit-objects/metadata/distribution/OnlineTransferOption.png

@jlblcc
Copy link
Member

jlblcc commented Jun 30, 2020

This looks fine. Are you using the https://github.com/adiwg/mdEditor-doc/blob/master/reference/include-objects?

@IronRico
Copy link
Contributor Author

IronRico commented Jul 14, 2020

I corrected the use of include-objects and also made sure the links in the Distribution section were working as well.

EDIT:

After running the build again, I noticed I cannot click on the link to open the correct page. It seems to know where to go as it will open in another window or allow me to save the markdown file. However, it will not open on click as with "offlineTransferOption". I am working to see what caused this issue.

@IronRico
Copy link
Contributor Author

Update 3

I worked to correct the navigation issues found in the Distribution section of the Summary.md file.

I replaced these with the following:

[Online Transfer Option](reference/edit-window/metadata/distribution-panels/ onlineTransferOption.md)
[Transfer Frequency] (reference/edit-window/metadata/distribution-panels/ timeDuration-obj.md)

I tested these items locally and found them to be working as intended.

This is noted in the rolling doc changes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Deals with documentation updates
Projects
None yet
Development

No branches or pull requests

4 participants