Fix set_port to return correct boolean value #836
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like checking that in the set_port (before the parse_port) does not cause some tests to fail... Now I am wondering about the fuzzers. |
I think fuzzers are unrelated. It's failing on another PR. |
anonrig
reviewed
Jan 10, 2025
| @@ -791,6 +791,12 @@ bool url::set_port(const std::string_view input) { | |||
| return false; | |||
| } | |||
|
|
|||
| uint16_t parsed_port{}; | |||
| std::from_chars(trimmed.data(), trimmed.data() + trimmed.size(), parsed_port); | |||
There was a problem hiding this comment.
This is going to be slower. can we do it inside parse_port()
There was a problem hiding this comment.
that was my initial attempt here e998da7, but these tests started failing:
6 - wpt_url_tests_typed.urltestdata_encoding<ada::url> (Failed)
9 - wpt_url_tests_typed.urltestdata_encoding<ada::url_aggregator> (Failed)
16 - url_components.urltestdata_encoding (Failed)
was my approach wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #826