Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Redux Toolkit Migration] prefsSlice #4127

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 10, 2025

@actual-github-bot actual-github-bot bot changed the title [Redux Toolkit Migration] prefsSlice [WIP] [Redux Toolkit Migration] prefsSlice Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0ae8b6d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6781b56ceae0520008913c98
😎 Deploy Preview https://deploy-preview-4127.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
18 5.92 MB → 5.96 MB (+47.93 kB) +0.79%
Changeset (largest 100 files by percent change)
File Δ Size
node_modules/immer/dist/immer.mjs 🆕 +17.74 kB 0 B → 17.74 kB
home/runner/work/actual/actual/packages/loot-core/src/client/queries/queriesSlice.ts 🆕 +13.1 kB 0 B → 13.1 kB
home/runner/work/actual/actual/packages/loot-core/src/client/budgets/budgetsSlice.ts 🆕 +10.6 kB 0 B → 10.6 kB
home/runner/work/actual/actual/packages/loot-core/src/client/accounts/accountsSlice.ts 🆕 +5.23 kB 0 B → 5.23 kB
home/runner/work/actual/actual/packages/loot-core/src/client/prefs/prefsSlice.ts 🆕 +2.66 kB 0 B → 2.66 kB
home/runner/work/actual/actual/packages/loot-core/src/client/modals/modalsSlice.ts 🆕 +2.02 kB 0 B → 2.02 kB
home/runner/work/actual/actual/packages/loot-core/src/client/notifications/notificationsSlice.ts 🆕 +1.37 kB 0 B → 1.37 kB
home/runner/work/actual/actual/packages/loot-core/src/client/app/appSlice.ts 🆕 +754 B 0 B → 754 B
home/runner/work/actual/actual/packages/loot-core/src/client/undo.ts 🆕 +560 B 0 B → 560 B
src/components/modals/NewCategoryGroupModal.tsx 🆕 +547 B 0 B → 547 B
src/components/modals/NewCategoryModal.tsx 🆕 +524 B 0 B → 524 B
home/runner/work/actual/actual/packages/loot-core/src/client/redux.ts 🆕 +57 B 0 B → 57 B
node_modules/@reduxjs/toolkit/dist/redux-toolkit.modern.mjs 📈 +17.97 kB (+354.33%) 5.07 kB → 23.04 kB
src/components/HelpMenu.tsx 📈 +775 B (+33.22%) 2.28 kB → 3.04 kB
src/index.tsx 📈 +198 B (+24.38%) 812 B → 1010 B
home/runner/work/actual/actual/packages/loot-core/src/client/store/index.ts 📈 +158 B (+15.99%) 988 B → 1.12 kB
src/gocardless.ts 📈 +123 B (+12.76%) 964 B → 1.06 kB
src/components/mobile/budget/index.tsx 📈 +1.23 kB (+10.68%) 11.52 kB → 12.75 kB
src/components/modals/EnvelopeBudgetSummaryModal.tsx 📈 +353 B (+10.43%) 3.31 kB → 3.65 kB
src/global-events.ts 📈 +301 B (+9.56%) 3.07 kB → 3.37 kB
home/runner/work/actual/actual/packages/loot-core/src/client/shared-listeners.ts 📈 +710 B (+8.58%) 8.08 kB → 8.77 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/sync.ts 📈 +124 B (+8.34%) 1.45 kB → 1.57 kB
src/hooks/useSyncedPref.ts 📈 +25 B (+7.42%) 337 B → 362 B
src/hooks/useGlobalPref.ts 📈 +31 B (+7.31%) 424 B → 455 B
src/hooks/useSyncedPrefs.ts 📈 +21 B (+7.24%) 290 B → 311 B
src/hooks/useMetadataPref.ts 📈 +25 B (+7.06%) 354 B → 379 B
src/components/budget/index.tsx 📈 +568 B (+6.08%) 9.13 kB → 9.68 kB
src/hooks/useTransactionBatchActions.ts 📈 +454 B (+5.73%) 7.74 kB → 8.18 kB
src/components/modals/CategoryAutocompleteModal.tsx 📈 +122 B (+5.27%) 2.26 kB → 2.38 kB
src/components/settings/AuthSettings.tsx 📈 +142 B (+4.67%) 2.97 kB → 3.11 kB
src/components/mobile/accounts/AccountTransactions.tsx 📈 +345 B (+4.48%) 7.52 kB → 7.86 kB
src/components/admin/UserAccess/UserAccessRow.tsx 📈 +154 B (+4.28%) 3.51 kB → 3.66 kB
src/components/modals/CloseAccountModal.tsx 📈 +434 B (+3.97%) 10.68 kB → 11.1 kB
src/components/modals/manager/DuplicateFileModal.tsx 📈 +270 B (+3.75%) 7.03 kB → 7.3 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/backups.ts 📈 +18 B (+3.37%) 534 B → 552 B
src/components/modals/AccountAutocompleteModal.tsx 📈 +70 B (+3.37%) 2.03 kB → 2.1 kB
src/components/ServerContext.tsx 📈 +102 B (+2.71%) 3.67 kB → 3.77 kB
src/components/modals/TransferOwnership.tsx 📈 +174 B (+2.69%) 6.32 kB → 6.49 kB
src/components/schedules/index.tsx 📈 +98 B (+2.67%) 3.59 kB → 3.68 kB
src/components/sidebar/Account.tsx 📈 +195 B (+2.51%) 7.59 kB → 7.78 kB
src/components/modals/manager/DeleteFileModal.tsx 📈 +135 B (+2.47%) 5.33 kB → 5.46 kB
src/components/modals/EditUser.tsx 📈 +312 B (+2.29%) 13.32 kB → 13.62 kB
src/components/payees/ManagePayeesWithData.tsx 📈 +78 B (+2.07%) 3.68 kB → 3.75 kB
src/components/admin/UserAccess/UserAccess.tsx 📈 +141 B (+2.05%) 6.71 kB → 6.84 kB
src/components/modals/SelectLinkedAccountsModal.jsx 📈 +165 B (+2.05%) 7.87 kB → 8.03 kB
src/components/modals/manager/ImportModal.tsx 📈 +84 B (+1.86%) 4.4 kB → 4.49 kB
src/components/admin/UserDirectory/UserDirectory.tsx 📈 +171 B (+1.82%) 9.16 kB → 9.32 kB
src/components/reports/Overview.tsx 📈 +256 B (+1.69%) 14.79 kB → 15.04 kB
src/components/transactions/TransactionMenu.tsx 📈 +45 B (+1.63%) 2.69 kB → 2.73 kB
src/components/manager/BudgetList.tsx 📈 +302 B (+1.62%) 18.16 kB → 18.45 kB
src/components/settings/Encryption.tsx 📈 +84 B (+1.62%) 5.08 kB → 5.16 kB
src/components/modals/CoverModal.tsx 📈 +47 B (+1.60%) 2.86 kB → 2.91 kB
src/components/ManageRules.tsx 📈 +139 B (+1.57%) 8.65 kB → 8.78 kB
src/components/modals/EditAccess.tsx 📈 +71 B (+1.51%) 4.59 kB → 4.66 kB
node_modules/redux/dist/redux.mjs 📈 +119 B (+1.39%) 8.33 kB → 8.45 kB
src/components/sidebar/Sidebar.tsx 📈 +39 B (+1.38%) 2.76 kB → 2.8 kB
src/components/accounts/Account.tsx 📈 +627 B (+1.36%) 44.86 kB → 45.47 kB
src/components/mobile/transactions/TransactionEdit.jsx 📈 +429 B (+1.25%) 33.6 kB → 34.02 kB
src/components/modals/manager/ImportYNAB5Modal.tsx 📈 +49 B (+1.20%) 3.97 kB → 4.02 kB
src/components/modals/CreateAccountModal.tsx 📈 +198 B (+1.20%) 16.06 kB → 16.25 kB
src/components/modals/manager/ImportYNAB4Modal.tsx 📈 +49 B (+1.20%) 3.97 kB → 4.02 kB
src/components/modals/TransferModal.tsx 📈 +49 B (+1.19%) 4.04 kB → 4.08 kB
src/components/schedules/ScheduleLink.tsx 📈 +41 B (+1.10%) 3.65 kB → 3.69 kB
src/components/modals/manager/ImportActualModal.tsx 📈 +49 B (+1.09%) 4.38 kB → 4.43 kB
src/components/FinancesApp.tsx 📈 +126 B (+1.06%) 11.59 kB → 11.71 kB
src/browser-preload.browser.js 📈 +43 B (+0.96%) 4.36 kB → 4.4 kB
src/components/manager/WelcomeScreen.tsx 📈 +38 B (+0.91%) 4.06 kB → 4.1 kB
src/components/reports/reports/CustomReportListCards.tsx 📈 +38 B (+0.86%) 4.32 kB → 4.35 kB
src/components/modals/CreateLocalAccountModal.tsx 📈 +63 B (+0.86%) 7.17 kB → 7.23 kB
src/components/App.tsx 📈 +48 B (+0.80%) 5.84 kB → 5.89 kB
src/components/modals/manager/FilesSettingsModal.tsx 📈 +48 B (+0.78%) 6 kB → 6.05 kB
src/components/manager/subscribe/OpenIdForm.tsx 📈 +110 B (+0.74%) 14.6 kB → 14.71 kB
src/components/mobile/budget/BudgetTable.jsx 📈 +403 B (+0.73%) 54.1 kB → 54.5 kB
src/components/reports/reports/Summary.tsx 📈 +110 B (+0.69%) 15.53 kB → 15.63 kB
src/components/modals/MergeUnusedPayeesModal.tsx 📈 +45 B (+0.67%) 6.55 kB → 6.59 kB
src/components/sidebar/Accounts.tsx 📈 +31 B (+0.66%) 4.61 kB → 4.64 kB
src/components/transactions/SelectedTransactionsButton.tsx 📈 +45 B (+0.56%) 7.9 kB → 7.94 kB
src/components/reports/reports/NetWorth.tsx 📈 +34 B (+0.53%) 6.26 kB → 6.3 kB
src/components/mobile/accounts/Accounts.tsx 📈 +40 B (+0.47%) 8.33 kB → 8.37 kB
src/hooks/useFailedAccounts.ts 📈 +1 B (+0.47%) 215 B → 216 B
src/components/modals/GoCardlessExternalMsgModal.tsx 📈 +39 B (+0.38%) 10.09 kB → 10.13 kB
src/components/reports/reports/CashFlow.tsx 📈 +34 B (+0.37%) 8.96 kB → 8.99 kB
src/components/accounts/AccountSyncCheck.tsx 📈 +22 B (+0.37%) 5.85 kB → 5.87 kB
src/components/Notifications.tsx 📈 +26 B (+0.36%) 6.97 kB → 7 kB
src/components/transactions/TransactionsTable.jsx 📈 +251 B (+0.36%) 67.37 kB → 67.62 kB
src/components/modals/ImportTransactionsModal/ImportTransactionsModal.jsx 📈 +104 B (+0.34%) 30.05 kB → 30.15 kB
src/components/modals/PasswordEnableModal.tsx 📈 +14 B (+0.32%) 4.26 kB → 4.27 kB
home/runner/work/actual/actual/packages/loot-core/src/platform/client/undo/index.web.ts 📈 +2 B (+0.27%) 743 B → 745 B
src/components/modals/manager/ConfirmChangeDocumentDir.tsx 📈 +18 B (+0.26%) 6.83 kB → 6.85 kB
src/components/autocomplete/PayeeAutocomplete.tsx 📈 +33 B (+0.22%) 14.87 kB → 14.9 kB
src/util/versions.ts 📈 +2 B (+0.19%) 1.01 kB → 1.01 kB
src/components/reports/reports/Spending.tsx 📈 +34 B (+0.17%) 19.76 kB → 19.79 kB
src/components/schedules/ScheduleDetails.tsx 📈 +53 B (+0.17%) 30.8 kB → 30.86 kB
src/components/mobile/transactions/TransactionList.jsx 📈 +25 B (+0.15%) 15.99 kB → 16.02 kB
src/components/reports/reports/Calendar.tsx 📈 +39 B (+0.15%) 26.11 kB → 26.15 kB
package.json 📈 +4 B (+0.13%) 2.97 kB → 2.97 kB
src/components/modals/PayeeAutocompleteModal.tsx 📈 +2 B (+0.11%) 1.75 kB → 1.75 kB
src/components/BankSyncStatus.tsx 📈 +1 B (+0.05%) 1.84 kB → 1.84 kB
src/components/settings/Export.tsx 📈 +1 B (+0.04%) 2.22 kB → 2.23 kB
src/components/UpdateNotification.tsx 📈 +1 B (+0.03%) 3.58 kB → 3.58 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.74 MB → 3.78 MB (+44.64 kB) +1.17%
static/js/narrow.js 84.3 kB → 86.3 kB (+2 kB) +2.37%
static/js/wide.js 104.78 kB → 105.53 kB (+770 B) +0.72%
static/js/ReportRouter.js 1.58 MB → 1.58 MB (+545 B) +0.03%
static/js/AppliedFilters.js 10.24 kB → 10.24 kB (+1 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/pl.js 17 B 0%
static/js/de.js 4.59 kB 0%
static/js/fr.js 12.6 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ta.js 17 B 0%
static/js/es.js 3.45 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/useAccountPreviewTransactions.js 1.63 kB 0%
static/js/en.js 93.64 kB 0%
static/js/zh-Hant.js 10.13 kB 0%
static/js/uk.js 120.7 kB 0%

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.33 MB 0%

@joel-jeremy joel-jeremy force-pushed the redux-toolkit-prefs-slice branch from c33712b to 0ae8b6d Compare January 11, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant