From b21f57f3ed555d558ed78fcf10bf4c2326935cf3 Mon Sep 17 00:00:00 2001
From: Henry Bley-Vroman <olets@olets.dev>
Date: Fri, 6 Sep 2024 09:11:47 -1000
Subject: [PATCH] Privacy mode: no layout shift when switching mode

---
 .../src/components/PrivacyFilter.tsx          | 57 ++++++++++++-------
 .../src/components/accounts/Balance.jsx       |  4 +-
 .../budget/report/ReportComponents.tsx        |  1 +
 .../budget/rollover/RolloverComponents.tsx    | 10 ----
 .../rollover/budgetsummary/ToBudgetAmount.tsx |  6 +-
 .../desktop-client/src/components/table.tsx   |  5 --
 6 files changed, 43 insertions(+), 40 deletions(-)

diff --git a/packages/desktop-client/src/components/PrivacyFilter.tsx b/packages/desktop-client/src/components/PrivacyFilter.tsx
index 2238cda905b..20028cf2743 100644
--- a/packages/desktop-client/src/components/PrivacyFilter.tsx
+++ b/packages/desktop-client/src/components/PrivacyFilter.tsx
@@ -7,6 +7,8 @@ import React, {
   type ReactNode,
 } from 'react';
 
+import { css } from 'glamor';
+
 import { usePrivacyMode } from '../hooks/usePrivacyMode';
 import { useResponsive } from '../ResponsiveProvider';
 
@@ -44,11 +46,9 @@ export function ConditionalPrivacyFilter({
 
 type PrivacyFilterProps = ComponentPropsWithRef<typeof View> & {
   activationFilters?: (boolean | (() => boolean))[];
-  lineHeight?: number;
 };
 export function PrivacyFilter({
   activationFilters,
-  lineHeight,
   children,
   ...props
 }: PrivacyFilterProps) {
@@ -63,43 +63,58 @@ export function PrivacyFilter({
         typeof value === 'boolean' ? value : value(),
       ));
 
-  const privacyLineHeight = lineHeight != null ? lineHeight : 'inherit';
-
   return !activate ? (
     <>{Children.toArray(children)}</>
   ) : (
-    <PrivacyOverlay lineHeight={privacyLineHeight} {...props}>
-      {children}
-    </PrivacyOverlay>
+    <PrivacyOverlay {...props}>{children}</PrivacyOverlay>
   );
 }
 
-function PrivacyOverlay({ lineHeight, children, ...props }) {
+function PrivacyOverlay({ children, ...props }) {
   const [hovered, setHovered] = useState(false);
   const onHover = useCallback(() => setHovered(true), [setHovered]);
   const onHoverEnd = useCallback(() => setHovered(false), [setHovered]);
 
-  const privacyStyle = {
-    ...(!hovered && {
-      fontFamily: 'Redacted Script',
-      lineHeight,
-    }),
-  };
-
   const { style, ...restProps } = props;
 
   return (
     <View
-      style={{
-        display: style?.display ? style.display : 'inline-flex',
-        ...privacyStyle,
-        ...style,
-      }}
+      className={`${css(
+        [
+          {
+            display: 'inline-flex',
+            position: 'relative',
+            ' > div:first-child': {
+              opacity: hovered ? 1 : 0,
+            },
+            ' > div:nth-child(2)': {
+              display: hovered ? 'none' : 'block',
+            },
+          },
+        ],
+        style,
+      )}`}
       onPointerEnter={onHover}
       onPointerLeave={onHoverEnd}
       {...restProps}
     >
-      {children}
+      <div>
+        <View>{children}</View>
+      </div>
+
+      <div
+        aria-hidden="true"
+        className={`${css({
+          fontFamily: 'Redacted Script',
+          height: '100%',
+          inset: 0,
+          pointerEvents: 'none',
+          position: 'absolute',
+          width: '100%',
+        })}`}
+      >
+        <View>{children}</View>
+      </div>
     </View>
   );
 }
diff --git a/packages/desktop-client/src/components/accounts/Balance.jsx b/packages/desktop-client/src/components/accounts/Balance.jsx
index a58678ef150..999f37ce56c 100644
--- a/packages/desktop-client/src/components/accounts/Balance.jsx
+++ b/packages/desktop-client/src/components/accounts/Balance.jsx
@@ -184,9 +184,7 @@ export function Balances({
                   ? theme.noticeTextLight
                   : theme.pageTextSubdued,
           })}
-          privacyFilter={{
-            lineHeight: 1.22,
-          }}
+          privacyFilter
         />
 
         <SvgArrowButtonRight1
diff --git a/packages/desktop-client/src/components/budget/report/ReportComponents.tsx b/packages/desktop-client/src/components/budget/report/ReportComponents.tsx
index d6ae0650bc2..ab727fb7cf4 100644
--- a/packages/desktop-client/src/components/budget/report/ReportComponents.tsx
+++ b/packages/desktop-client/src/components/budget/report/ReportComponents.tsx
@@ -175,6 +175,7 @@ export const GroupMonth = memo(function GroupMonth({
           valueProps={{
             binding: reportBudget.groupBalance(id),
             type: 'financial',
+            // TODO: may no longer be unnecessary
             privacyFilter: {
               style: {
                 paddingRight: styles.monthRightPadding,
diff --git a/packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx b/packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx
index ab107196717..480e74880ac 100644
--- a/packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx
+++ b/packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx
@@ -165,11 +165,6 @@ export const ExpenseGroupMonth = memo(function ExpenseGroupMonth({
         valueProps={{
           binding: rolloverBudget.groupBalance(id),
           type: 'financial',
-          privacyFilter: {
-            style: {
-              paddingRight: styles.monthRightPadding,
-            },
-          },
         }}
       />
     </View>
@@ -425,11 +420,6 @@ export function IncomeGroupMonth({ month }: IncomeGroupMonthProps) {
         valueProps={{
           binding: rolloverBudget.groupIncomeReceived,
           type: 'financial',
-          privacyFilter: {
-            style: {
-              paddingRight: styles.monthRightPadding,
-            },
-          },
         }}
       />
     </View>
diff --git a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx
index 9812e89c45c..ae85080afd7 100644
--- a/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx
+++ b/packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx
@@ -64,7 +64,11 @@ export function ToBudgetAmount({
           offset={3}
           triggerProps={{ isDisabled: isTotalsListTooltipDisabled }}
         >
-          <PrivacyFilter lineHeight={1.2}>
+          <PrivacyFilter
+            style={{
+              textAlign: 'center',
+            }}
+          >
             <Block
               onClick={onClick}
               data-cellname={sheetName}
diff --git a/packages/desktop-client/src/components/table.tsx b/packages/desktop-client/src/components/table.tsx
index 7b0a3ecc45f..70516e17232 100644
--- a/packages/desktop-client/src/components/table.tsx
+++ b/packages/desktop-client/src/components/table.tsx
@@ -197,11 +197,6 @@ export function Cell({
         privacyFilter={mergeConditionalPrivacyFilterProps(
           {
             activationFilters: [!focused, !exposed],
-            style: {
-              position: 'absolute',
-              width: '100%',
-              height: '100%',
-            },
           },
           privacyFilter,
         )}