Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neither global.sql.datasource.username.secretRef/Key nor *SetupJob.username.secretRef/Key work #531

Open
megri opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@megri
Copy link

megri commented Jan 14, 2025

Describe the bug
Using chart version 0.4.39 which is latest version at the time of writing.

When setting any *.username.secretRef/secretKey the chart won't build properly and errors out with

Error: could not merge values: wrong node kind: expected ScalarNode but got MappingNode: node contents:
secretKey: bar
secretRef: foo

To Reproduce
Using this kustomization.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
helmCharts:
  - name: datahub-prerequisites
    releaseName: datahub-prerequsites
    repo: https://helm.datahubproject.io/
    version: 0.1.13
  - name: datahub
    releaseName: datahub
    repo: https://helm.datahubproject.io/
    version: 0.4.39
    valuesInline:
      global:
        sql:
          datasource:
            username:
              secretRef: foo
              secretKey: bar

the error can be observed.

Expected behavior
Templates seem to indicate that it should be possible to set the username by secret, like here:

These PR also indicate that this should be supported:

@megri megri added the bug Something isn't working label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant