Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datahub-frontend chart OIDC support incomplete #529

Open
jdnurmi opened this issue Jan 13, 2025 · 0 comments · May be fixed by #530
Open

datahub-frontend chart OIDC support incomplete #529

jdnurmi opened this issue Jan 13, 2025 · 0 comments · May be fixed by #530
Labels
bug Something isn't working

Comments

@jdnurmi
Copy link

jdnurmi commented Jan 13, 2025

Describe the bug
The default chart only allows a few hard-coded OIDC providers (oidcAuthentication.providers)

Expected behavior
Any OIDC provider should work (within some bounds of normal operations)

Additional context

For my clients configuration, I did a micro patch:

diff --git a/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml b/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
index b45e53e..45f9d69 100644
--- a/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
+++ b/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml
@@ -242,6 +242,11 @@ spec:
               value: https://login.microsoftonline.com/{{ .azureTenantId }}/v2.0/.well-known/openid-configuration
             - name: AUTH_OIDC_SCOPE
               value: {{ .scope | default "openid profile email" }}
+            {{- else if .issuerUrl }}
+            - name: AUTH_OIDC_DISCOVERY_URI
+              value: {{ .issuerUrl }}/.well-known/openid-configuration
+            - name: AUTH_OIDC_SCOPE
+              value: {{ .scope | default "openid profile email" }}
             {{- else }}
             {{- fail (printf "unsupported .oidcAuthentication.provider value '%s'" .provider) }}
             {{- end }}

Which allowed me to enable an arbitrary provider (in our case, OneLogin). There may be better ways to achieve this, so I defer to the chart-keepers on their preferred solution - but in case someone else comes looking, hopefully they'll find this.

@jdnurmi jdnurmi added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant