-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss ADR: Media Manager Architecture #851
Comments
Per discussion on another platform:
|
Some of my thoughts on the questions:
|
Proposing a workflow to consider as it may relate to the development of this feature (assuming my understanding of everything is correct so far):
|
The module will need to take an action (IE 'check in') a media file even if its in the search pattern it provides. We do not currently export all files matching these patterns, and I don't think we should. We may want to provide a similar type of 'check in' type function for non-media type files. I am thinking plist, sqlite, or other parsed data files. These currently only get exported if the module does it in its own code. edit: We should not assume that all files in a pattern match are relevant to what the module or artifact is attempting to parse. Some of the patterns have to include a lot to access the true target files. |
Some of my thoughts after reading this discussion but I am pretty sure new ones will come during the implementation phase. Regarding the check_in_media function:
Concerns about performance:
Implemetation
|
As I am thinking over this, a note I want to include is that I think we will end up not storing these media files in their original paths. I think we may go more similar to how itunes backups are stored. have a media folder and probably even subfolders inside, although i dont think we need the 2 hex character prefix. the checkin function would sha1 the given file and store the file in the subfolder that matches its first char in the sha1. file should have its appropriate extension for its type (jpg, pdf, etc) for ease of opening. this way, if an image that exists in the photo album was also sent in an imessage we identify that they are matching hashes and record each location as a reference. |
Media Manager Implementation Discussion
We're proposing a new Media Management System to centralize and streamline how we handle media files across different modules in our project. This issue is to discuss the proposed architecture and technical specifications.
Key Points:
Proposed Changes:
check_in_media
function that modules will use to register media filesmedia_items
andmedia_references
MediaReference
objects as cell valuesMediaReference
objectsDocuments for Review:
Questions for Discussion:
check_in_media
function signature sufficient? Should we add or remove any parameters?Please review the linked documents and share your thoughts, concerns, or suggestions.
The text was updated successfully, but these errors were encountered: