Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone Handling #850

Open
JamesHabben opened this issue Oct 11, 2024 · 0 comments
Open

Timezone Handling #850

JamesHabben opened this issue Oct 11, 2024 · 0 comments

Comments

@JamesHabben
Copy link
Collaborator

JamesHabben commented Oct 11, 2024

Discussion: Timezone Handling Approach

This issue is for discussing the proposed approach to timezone handling in our project, as outlined in the draft ADR: Timezone Handling in Project.

Summary of Proposed Approach

  1. Standardize timestamp formats across modules
  2. Maintain the timezone_offset parameter for TSV and KML outputs
  3. Convert all timestamps to UTC for LAVA output
  4. Update timestamp conversion functions

Key Discussion Points

  1. Is the proposed approach comprehensive enough to address our timezone challenges?
  2. Are there any potential drawbacks or risks we haven't considered?
  3. How will this approach impact existing modules and workflows?
  4. Is maintaining the timezone_offset parameter the best approach for TSV and KML outputs?
  5. Are there any alternative approaches we should consider?

Questions for Consideration

  • Does this approach provide sufficient flexibility for future requirements?
  • How will this impact our development and testing processes?
  • Are there any performance implications we should be aware of?

Next Steps

  1. Team members to review the draft ADR and provide feedback
  2. Discuss any concerns or suggestions in this issue
  3. Refine the ADR based on the discussion
  4. Make a final decision on the approach

Please share your thoughts, concerns, or suggestions regarding the proposed timezone handling approach. Your input is crucial in finalizing this architectural decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant