New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps issues #840

Open

Johann-PLW opened this issue Oct 6, 2024 · 1 comment

Labels

Collaborator

Johann-PLW commented Oct 6, 2024

Issues

Timestamps in HTML were not able to support timezone offset parameter.
Inconsistencies were observed between HTML and SQLite. I noticed that timestamps were not added appropriately in the lava SQLite. Timestamps are stored in the plist file as datetime objets and not str. When they were converted to be added in the SQLite database, datetime objets were considered in local time instead of UTC and then were converted in UTC.

Corrective action
A new convert_plist_date_to_timezone_offset function was created in ilapfuncs.py to:

manage date objets 'YYYY-MM-DDTHH:MM:SSZ' in plist files
convert them to support timezone offset chosen by the user
add them in the correct timestamp in the lava SQLite database

Johann-PLW added the documentation label

Collaborator

JamesHabben commented Oct 12, 2024

looks like not merged yet?

i am updating the module update guide based on this. can you review, correct, or add whatever needs to be included to help with this part of module updates?
https://github.com/abrignoni/iLEAPP/blob/lava-output/admin/docs/module_updates.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment