Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary slash at the end of explorer link leads to incorrect final link #2315

Closed
miguelmtzinf opened this issue Jan 14, 2025 · 0 comments · Fixed by #2316
Closed

Unnecessary slash at the end of explorer link leads to incorrect final link #2315

miguelmtzinf opened this issue Jan 14, 2025 · 0 comments · Fixed by #2316
Assignees
@CanonicalJP

Comments

@miguelmtzinf
Copy link
Contributor

Zksync, Scroll and BNB explorer links have an unnecessary / at the end, which causes having incorreclty formatted final URLs.

Because of this configuration:

interface/src/ui-config/networksConfig.ts

Line 390 in 937b265

explorerLink: 'https://era.zksync.network/',

We ended up with
https://era.zksync.network//address/0x5aea5775959fbc2557cc8789bc1bf90a239d9a91
instead of
https://era.zksync.network//address/0x5aea5775959fbc2557cc8789bc1bf90a239d9a91
for WETH underlying.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CanonicalJP CanonicalJP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary slash in explorer links [skip cypress] aave/interface
2 participants
@miguelmtzinf @CanonicalJP