Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorStoreFiles(after = ...) uses VectorStoreId instead of FileId #410

Open
BlackBaroness opened this issue Jan 12, 2025 · 0 comments
Open

Comments

@BlackBaroness
Copy link

Looks like the API contract here is not correct, since it's just not possible for VectorStoreId to be here. We iterate files inside the one single specific vector store

public suspend fun vectorStoreFiles(
        id: VectorStoreId,
        limit: Int? = null,
        order: SortOrder? = null,
        after: VectorStoreId? = null, // this
        before: VectorStoreId? = null, // and this
        filter: Status? = null,
        requestOptions: RequestOptions? = null,
    ): List<VectorStoreFile>

I believe it should receive VectorStoreFile.id (FileId) here.

@BlackBaroness BlackBaroness changed the title VectorStores.vectorStores(after = ...) uses VectorStoreId instead of FileId vectorStoreFiles(after = ...) uses VectorStoreId instead of FileId Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant