New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide detailed error objects #45

Open

multimeric opened this issue Sep 9, 2020 · 0 comments

Assignees

Labels

Milestone

Collaborator

multimeric commented Sep 9, 2020

We have a few "expected" errors:

We killed the execution of the command because it timed out (in one of 3 ways)
We were given a string to parse that is too long

In these cases, we currently return an empty command which is implicitly "failed" since it has no arguments.

However, in these situations it is likely more helpful to throw an exception. This should be handled such that:

When running the CLI, this message is returned to the user (likely via logging)
When running via the Python API, this can be caught
When running in the Automation repo, we can store a structured error

multimeric self-assigned this

multimeric added this to the 3.0.0 milestone

multimeric added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment