Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkmate to check inputs #17

Open
Robinlovelace opened this issue May 24, 2021 · 2 comments
Open

Use checkmate to check inputs #17

Robinlovelace opened this issue May 24, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Robinlovelace
Copy link
Collaborator

This could help generate useful error messages and reduce the chances of the package outputting incorrect results due to incorrect input data. See https://github.com/mllg/checkmate for details.

I see this as a nice to have rather than essential and time may be better spent on creating a formal class system for OD data as per itsleeds/od#20

@Robinlovelace Robinlovelace added good first issue Good for newcomers help wanted Extra attention is needed labels May 24, 2021
@natesheehan
Copy link
Collaborator

+1 this would still be good to add in. When I get some time I am happy to look at this, maybe after the next release.

@Robinlovelace
Copy link
Collaborator Author

I don't think it's a priority but yes some defensive programming to identify dodgy inputs early could be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants