Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching and revalidation of expired resources #543

Closed
jowerner opened this issue Dec 20, 2024 · 0 comments · Fixed by #549
Closed

Fix caching and revalidation of expired resources #543

jowerner opened this issue Dec 20, 2024 · 0 comments · Fixed by #549
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jowerner
Copy link
Contributor

XLT does not behave exactly like browsers when it comes to caching resources and revalidating expired resources. In particular, XLT takes the "no-cache" directive literally and re-requests such resources while browsers perform a conditional get to revalidate the resource.

@jowerner jowerner self-assigned this Dec 20, 2024
@jowerner jowerner added the bug Something isn't working label Dec 20, 2024
@jowerner jowerner added this to the 8.6.0 milestone Dec 20, 2024
@jowerner jowerner linked a pull request Jan 10, 2025 that will close this issue
h-arlt pushed a commit that referenced this issue Jan 13, 2025
* * cache responses even if they are marked with "no-cache" or are already expired (they will be revalidated before next use)
* fixed calculation of expiration time
* adjusted test cases accordingly

* feedback from reviewer

* Ignore "must-revalidate" for now. It makes only sense together with "max-age", and if a resource has reached its max age, it will be re-validated anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant