Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert separate optimization with wasm-opt #25

Open
vbar opened this issue Jan 5, 2023 · 0 comments
Open

Revert separate optimization with wasm-opt #25

vbar opened this issue Jan 5, 2023 · 0 comments

Comments

@vbar
Copy link
Collaborator

vbar commented Jan 5, 2023

After the fix of XRPL-Labs/xrpld-hooks#58 is applied, we can probably revert to optimizing directly with LLVM, improving compilation speed & removing an opaque binary from the docker container - unless LLVM optimization is measurably worse than wasm-opt, which should probably be checked against the existing Hook examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vbar