Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details on Session Identifier are not clear in the Explainer #55

Open
tblachowicz opened this issue Apr 26, 2024 · 2 comments
Open

Details on Session Identifier are not clear in the Explainer #55

tblachowicz opened this issue Apr 26, 2024 · 2 comments
Labels
Has initial answer Has at least one answer from admins

Comments

@tblachowicz
Copy link

In the high-level overview diagram there is example of Sec-Session-Registration header returned by the server which contains both session_identifier and challange as named parameters. However, further in more detailed description of the Start Session flow the session_identifier is not present in the examples for Sec-Session-Registration headers. I think the identifier of the session is required in the header as indicated in the overview section.

Furthermore, the proposed structure of the Registration JWT described in Start Session section of the Explainer does not mention if and how the identifier of the session is going to be provided by the Browser to the Server. I think this is required so the Server can match the registration request sent by the Browser to the sign-in flow response. If my understanding is incorrect, please clarify that aspect of the registration flow.

@drubery
Copy link
Collaborator

drubery commented Dec 18, 2024

This bug is fairly old (sorry for the delay!), but I think the current text should be more clear about this.

Sec-Session-Registration should not include a session_identifier. The session_identifier is returned here after registration succeeds. Servers can join the initial login attempt with the later session registration by setting a cookie on the login attempt that is sent to the registration endpoint.

Does that clear things up, or do you think the current language still needs work?

@kmonsen
Copy link
Collaborator

kmonsen commented Dec 18, 2024

There is also an optional authorization parameter that will be sent by the client in the registration request, the server can use this to correlate them.

@kmonsen kmonsen added the Has initial answer Has at least one answer from admins label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has initial answer Has at least one answer from admins
Projects
None yet
Development

No branches or pull requests

3 participants