Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket exceeds message length #7

Open
beasteers opened this issue Jul 20, 2022 · 0 comments
Open

websocket exceeds message length #7

beasteers opened this issue Jul 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@beasteers
Copy link
Contributor

Sometimes when querying multiple streams, especially multiple videos, the message size of each payload can be too big when it tries to send everything at once and it will crash the websocket.

To fix that, maybe we want to send one stream per message instead. Although that may also mean we want to add some helper utilities to ptgctl to handle synchronizing the data streams (knowing when the next batch of streams has come in and we should begin processing or if we should wait for more messages).

relevant lines
https://github.com/VIDA-NYU/ptg-api-server/blob/main/app/routers/data.py#L151-L153

@beasteers beasteers added bug Something isn't working help wanted Extra attention is needed labels Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants