Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in points to voxel function #114

Open
afroowoo opened this issue Jun 12, 2020 · 0 comments
Open

Possible bug in points to voxel function #114

afroowoo opened this issue Jun 12, 2020 · 0 comments

Comments

@afroowoo
Copy link

Hi, in the _points_to_voxel_kernel function below at

https://github.com/poodarchu/Det3D/blob/9fca2d94e4a138b6a2cd5d3fe4f4de38eb760306/det3d/ops/point_cloud/point_cloud_ops.py#L100-L101

shouldn't the loop continue instead of break?

By breaking the points loop we stop exploring new points that might have been assigned to an existing voxel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afroowoo