Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout bits #5

Open
CFanselow opened this issue Oct 26, 2015 · 24 comments
Open

layout bits #5

CFanselow opened this issue Oct 26, 2015 · 24 comments
Labels

Comments

@CFanselow
Copy link
Collaborator

a number of small layout issues

@CFanselow
Copy link
Collaborator Author

Nr. 1
seriesmisplaced

that's on the main page, the series are not listed below the heading "series"

@CFanselow
Copy link
Collaborator Author

Nr. 2
bottonsdontfit

@CFanselow
Copy link
Collaborator Author

Nr. 3
spacemissing

space between triangle and word
also in

  • website settings, languages
  • administration, hosted presses
  • approve proofs window
  • Download From Press Website (in tabs for publication formats)
    (I will stop reporting it now, hope the list lets you identify the rule)

@CFanselow
Copy link
Collaborator Author

Nr. 4
bordermissing

border missing

@CFanselow
Copy link
Collaborator Author

Nr. 5
I couldn't identify the tabs here. I was looking for the button to determine the publication format (even though I am used to it from the old design).

tabsnotclear

@asmecher
Copy link

@CFanselow, regarding #5 (comment) -- try checking out the asmecher/i825-fix branch, both for omp and lib-pkp. I haven't merged this in yet, but those changes will get rid of the tab set and improve/simplify the approval process considerably. (Sorry, I should've mentioned this branch -- heads-up also to @withanage and @bozana.)

@bozana
Copy link
Collaborator

bozana commented Oct 27, 2015

@asmecher, could it be that those changes (wehn rebased with the PKP master branches) break the layout when the user is logged in? Or is it something wrong on my side?

@NateWr
Copy link

NateWr commented Oct 27, 2015

Thanks for this. OMP still has a number of issues like this to work out on the backend. It hasn't had as much testing in the backend as OJS had in the run-up to 3.0 beta, but I do plan a more comprehensive review. I'd expect just about everything to change on the frontend but it's getting a more comprehensive treatment right now.

@asmecher What would you recommend to make sure we don't lose track of this? Should an issue be opened on pkp/pkp-lib pointing to this issue?

@CFanselow
Copy link
Collaborator Author

Nr. 6
The catalog entry is full screen (after saving two times??)

catalogentryfullscreen

@CFanselow
Copy link
Collaborator Author

Nr. 7
in the dashboard, tab: homepage

linkcovered

@NateWr
Copy link

NateWr commented Oct 27, 2015

Thanks @CFanselow, this one was fixed yesterday. It's the same problem as the fourth screenshot you posted above.

@CFanselow
Copy link
Collaborator Author

@NateWr
I'll give them numbers now, for reference.

@kadowa
Copy link

kadowa commented Oct 27, 2015

(8) Extended metadata fields
extended_metadata

@asmecher
Copy link

Note that if you're experiencing strange layout problems you may need to flush your cache. Delete any .css files from your cache/ subdirectory and they'll be re-generated.

@asmecher
Copy link

Regarding #5 (comment) -- I've merged that branch into master; you should be able to get the newest everything by switching back there (for omp and lib/pkp).

@asmecher
Copy link

@NateWr, is there a specific comment you're responding to with #5 (comment)?

@NateWr
Copy link

NateWr commented Oct 27, 2015

@asmecher No that was just a general comment.

@asmecher
Copy link

Re: #5 (comment) -- I'd suggest we track it here, but use [ ] to add checkboxes that look like this:

  • The layout of xyz is broken

That way individual notes can be marked finished. Then as we wrap up this round of testing anything that's not resolved can be moved into the regular issue list on the PKP repository.

@NateWr
Copy link

NateWr commented Oct 27, 2015

Ok, just that I will probably forget this exists as soon as comments stop coming in. Having it in pkp-lib issues and assigned to a milestone will keep it from getting lost.

@asmecher
Copy link

This will backstop it: pkp/pkp-lib#840

@kadowa
Copy link

kadowa commented Oct 29, 2015

  • Half-hidden tasks
    tasks

@kadowa
Copy link

kadowa commented Oct 29, 2015

  • Missing tasks/presses as lists get too long (Dashboard)

journals

(there are two more presses that are not shown)

tasks2

@CFanselow
Copy link
Collaborator Author

When deleting a plugin, the locale referencing the display name of the plugin is not found and thus ##plugins.generic.name.displayName## is displayed.

@asmecher
Copy link

The plugin deletion key problem mentioned here is noted over at pkp/pkp-lib#1523.

nils-stefan-weiher pushed a commit that referenced this issue Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants