Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app playground: listening for load progress #819

Open
rubenfiszel opened this issue Jan 6, 2025 · 2 comments
Open

app playground: listening for load progress #819

rubenfiszel opened this issue Jan 6, 2025 · 2 comments

Comments

@rubenfiszel
Copy link

Hi,

If you load https://typefox.github.io/monaco-languageclient/ghp_appPlayground.html, you should see that first it loads a white editor and then the theme is loaded and it becomes properly themed. That's content/color shift that I'd like to avoid for our users. It would likely be enough for us to wait for the themeService to be loaded and waiting for that to show a properly themed overlay/progress bar. I was wondering if there were any suggestions around getting:

  • progress of items being loaded so we can bump the progress bar
  • know when the themeService is sufficiently loaded that it would display the proper colors
  • know when the full editor + workspace has been loaded in case we want to avoid all content shift.
@CGNonofr
Copy link
Collaborator

CGNonofr commented Jan 6, 2025

In VSCode, the storage service is used to load the current theme faster (if it didn't change since the last visit)

So you can try:

  • loading the storage service
  • make sure the theme is set in the configuration BEFORE loading the services (by using initUserConfiguration)

@kaisalmen
Copy link
Collaborator

kaisalmen commented Jan 6, 2025

A PR is up for adding the suggestion to the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants