Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first row of input files #993

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

datejada
Copy link
Member

@datejada datejada commented Jan 10, 2025

Remove the first row that is not being used in the model.

Related issues

Closes #991

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • [NA] Docs were updated and workflow is passing

@datejada
Copy link
Member Author

@abelsiqueira and @suvayu This PR attempts to remove the first row of the input files as we discussed. To make it work we need to change the defaults in TulipaIO here:

https://github.com/TulipaEnergy/TulipaIO.jl/blob/6bc433b0c087ff1ae3d0806078445817c4eb56d6/src/pipeline.jl#L9

The easy/fast solution is to change the values in TulipaIO and rerelease them. But, maybe there is a more robust way for possible future changes. I created the issue anyway for TulipaIO:

TulipaEnergy/TulipaIO.jl#85

What do you think is the best way to go forward?

Thanks!

@suvayu
Copy link
Member

suvayu commented Jan 10, 2025

I consider the way defaults are set in TIO temporary, so anything that removes them is very welcome.

@abelsiqueira
Copy link
Member

New release of TulipaIO is the way to go, in my opinion

@datejada datejada force-pushed the 991-remove-first-row-files branch from 8322feb to 1db5e3e Compare January 21, 2025 15:04
@datejada datejada marked this pull request as ready for review January 21, 2025 15:05
@datejada
Copy link
Member Author

@abelsiqueira and @suvayu, this PR are ready to review; it uses TulipaIO v0.3.0

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (602a229) to head (1db5e3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #993   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          29       29           
  Lines        1151     1151           
=======================================
  Hits         1096     1096           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datejada datejada merged commit 7f70787 into TulipaEnergy:main Jan 21, 2025
6 of 7 checks passed
@datejada datejada deleted the 991-remove-first-row-files branch January 21, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove first row from the input files
3 participants