-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove first row of input files #993
Remove first row of input files #993
Conversation
@abelsiqueira and @suvayu This PR attempts to remove the first row of the input files as we discussed. To make it work we need to change the defaults in TulipaIO here: The easy/fast solution is to change the values in TulipaIO and rerelease them. But, maybe there is a more robust way for possible future changes. I created the issue anyway for TulipaIO: What do you think is the best way to go forward? Thanks! |
I consider the way defaults are set in TIO temporary, so anything that removes them is very welcome. |
New release of TulipaIO is the way to go, in my opinion |
8322feb
to
1db5e3e
Compare
@abelsiqueira and @suvayu, this PR are ready to review; it uses TulipaIO v0.3.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 29 29
Lines 1151 1151
=======================================
Hits 1096 1096
Misses 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Remove the first row that is not being used in the model.
Related issues
Closes #991
Checklist