Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up "plunder_lost_by_nation" statistic #804

Open
Goosius1 opened this issue Apr 13, 2023 · 0 comments
Open

Clean up "plunder_lost_by_nation" statistic #804

Goosius1 opened this issue Apr 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Goosius1
Copy link
Collaborator

Goosius1 commented Apr 13, 2023 •
edited
Loading

Describe the bug

  • With current code, the indicated stat is recorded but not displayed
  • It is not displayed, because in SW2.0.0 if a besieger were to invade before plundering, this would throw the stat off, as they would be plundering their own nation
  • Consider what to do with the code:
    • The recording code could just be removed
    • Or it could be fixed, with some metadata added to the siege object to fix
    • Additionally other useful stats could be added to the war history, which is now in a nice hover-box
      • It could be worthwhile asking servers what stats they would like before proceeding.
@Goosius1 Goosius1 added the bug Something isn't working label Apr 13, 2023
@Goosius1 Goosius1 changed the title Suggestion: Clean up "plunder_lost_by_nation" statistic Clean up "plunder_lost_by_nation" statistic Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Goosius1