From 82199423e6eb3c6cd2868c3e144c11c4ee79c20b Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 10:30:22 +0000 Subject: [PATCH 1/6] Corrected link to ISO 3166-1-alpha-2 --- schema/360-giving-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/360-giving-schema.json b/schema/360-giving-schema.json index 0a4ee1d1..3ac6b57d 100644 --- a/schema/360-giving-schema.json +++ b/schema/360-giving-schema.json @@ -726,7 +726,7 @@ "ZM", "ZW" ], - "description": "The 2-character ISO Country Code of the location of this activity. Taken from [ISO-3166-1-alpha-2](https://www.iso.org/iso-3166-country-codes.html)", + "description": "The 2-character ISO Country Code of the location of this activity. Taken from [ISO-3166-1-alpha-2](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2)", "weight": 2, "title": "Country Code" }, From 3b493c06db9ec97c241d6b73973e1608410a107e Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 10:31:32 +0000 Subject: [PATCH 2/6] Modified link to ONS coding system --- schema/360-giving-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/360-giving-schema.json b/schema/360-giving-schema.json index 3ac6b57d..6fd5effd 100644 --- a/schema/360-giving-schema.json +++ b/schema/360-giving-schema.json @@ -762,7 +762,7 @@ "string", "null" ], - "description": "A code referring to a geographical area, drawn from an established gazetteer such as the [ONS Register of Geographic Codes](https://data.gov.uk/dataset/389511fa-eb72-4657-a2ef-b3c982ec4c0e/register-of-geographic-codes-april-2020-for-the-united-kingdom) in the UK. For example, the code for a local authority ward, or parliamentary constituency.", + "description": "A code referring to a geographical area, drawn from an established gazetteer such as the [ONS Register of Geographic Codes](https://en.wikipedia.org/wiki/ONS_coding_system) in the UK. For example, the code for a local authority ward, or parliamentary constituency.", "weight": 5, "title": "Geographic Code" }, From 86c48d26a0601389a9644564105372f3d5f0743a Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 10:33:35 +0000 Subject: [PATCH 3/6] Removed recipient specific language from address component definitions --- schema/360-giving-schema.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/schema/360-giving-schema.json b/schema/360-giving-schema.json index 6fd5effd..aa134ff7 100644 --- a/schema/360-giving-schema.json +++ b/schema/360-giving-schema.json @@ -926,31 +926,31 @@ }, "streetAddress": { "type": "string", - "description": "Recipient organisation address building number and street name.", + "description": "Organisation address building number and street name.", "weight": 3.1, "title": "Street Address" }, "addressLocality": { "type": "string", - "description": "Recipient organisation address city or town.", + "description": "Organisation address city or town.", "weight": 3.2, "title": "City" }, "addressRegion": { "type": "string", - "description": "Recipient organisation address county", + "description": "Organisation address county", "weight": 3.3, "title": "County" }, "addressCountry": { "type": "string", - "description": "Recipient organisation address country", + "description": "Organisation address country", "weight": 3.5, "title": "Country" }, "postalCode": { "type": "string", - "description": "Recipient organisation address postal code.", + "description": "Organisation address postal code.", "weight": 3.4, "title": "Postal Code" }, From 8656c43b1cdfa459bb1811b13121c4c916c3edfd Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 10:34:22 +0000 Subject: [PATCH 4/6] Remove link to JSON schema documetnation in package schema for date-time --- schema/360-giving-package-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/360-giving-package-schema.json b/schema/360-giving-package-schema.json index 517d1301..291df4e6 100644 --- a/schema/360-giving-package-schema.json +++ b/schema/360-giving-package-schema.json @@ -29,7 +29,7 @@ }, "issued": { "title": "Issued", - "description": "The date that this data package was issued. The date must be written as YYYY-MM-DD, or in [full date-time format](https://json-schema.org/understanding-json-schema/reference/string.html#dates-and-times)", + "description": "The date that this data package was issued. The date must be written as YYYY-MM-DD, or in full date-time format", "type": "string", "oneOf": [ {"format": "date-time"}, From 42c3126d63ad305d7e78784548e4c02258ca7d1d Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 11:16:37 +0000 Subject: [PATCH 5/6] Added descriptions for various fields --- schema/360-giving-schema.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/schema/360-giving-schema.json b/schema/360-giving-schema.json index aa134ff7..fbd8340f 100644 --- a/schema/360-giving-schema.json +++ b/schema/360-giving-schema.json @@ -1171,7 +1171,7 @@ "$ref": "#/definitions/Event" }, "type": "array", - "description": "When did this grant activity actually take place. Dates should be in YYYY-MM-DD format. A date range can include a start date and duration in months, or a start and end date.", + "description": "When did this grant activity actually take place. Dates must be in YYYY-MM-DD or date-time format. A date range can include a start date and duration in months, or a start and end date.", "weight": 5.041, "title": "Actual Dates" }, @@ -1235,7 +1235,7 @@ "$ref": "#/definitions/GrantProgramme" }, "type": "array", - "description": "-", + "description": "Information about the grant programme under which the grant was awarded", "weight": 5, "title": "Grant Programme", "rollUp": [ @@ -1259,7 +1259,7 @@ "$ref": "#/definitions/Classification" }, "type": "array", - "description": "-", + "description": "Information about the type of funding provided by the grant", "weight": 5, "title": "Funding Type" }, @@ -1268,7 +1268,7 @@ "$ref": "#/definitions/Classification" }, "type": "array", - "description": "-", + "description": "Information about a classification associated with the grant", "weight": 5, "title": "Classifications" }, @@ -1277,7 +1277,7 @@ "$ref": "#/definitions/Documents" }, "type": "array", - "description": "-", + "description": "Information about a document related to the grant", "weight": 5, "title": "Related Document" }, From e335bb6428a061f7b60ba364cf28c3c3f17dc96f Mon Sep 17 00:00:00 2001 From: Matt Marshall Date: Tue, 23 Nov 2021 11:58:43 +0000 Subject: [PATCH 6/6] Updated description of FundingOrg:Location --- schema/360-giving-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schema/360-giving-schema.json b/schema/360-giving-schema.json index fbd8340f..779cd5a4 100644 --- a/schema/360-giving-schema.json +++ b/schema/360-giving-schema.json @@ -999,7 +999,7 @@ "$ref": "#/definitions/Location" }, "type": "array", - "description": "-", + "description": "Information about the location of the organisation.", "weight": 5, "title": "Location" },