Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page editor doesn't handle <textarea> well #114

Open
joachimschmidt557 opened this issue Jul 28, 2019 · 2 comments
Open

Page editor doesn't handle <textarea> well #114

joachimschmidt557 opened this issue Jul 28, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@joachimschmidt557
Copy link

The HTML editor for pages doesn't seem to handle <textarea> well:

image

The text A more complete example should be part of the page to be edited.
@juancarlospaco juancarlospaco added bug Something isn't working cosmetic Visual/UI related labels Jul 28, 2019
@ThomasTJdev
Copy link
Owner

Confirmed, this is a bug. The page data is inserted into a <textarea id="editordataCodemirror">, which codemirror formats. The problem occurs, when the pagedata also includes <textarea>-fields, due to codemirror is closing the editor on first </textarea>.

@ThomasTJdev ThomasTJdev added help wanted Extra attention is needed and removed cosmetic Visual/UI related labels Sep 1, 2019
@juancarlospaco
Copy link
Collaborator

juancarlospaco commented Sep 22, 2019 •
edited
Loading

Solution https://stackoverflow.com/a/2844617 ❔

More of a CodeMirror bug than our bug, but still. 🤷‍♀️

ThomasTJdev added a commit that referenced this issue Dec 28, 2019
@ThomasTJdev
Fix of UI in #114. Only on default code.
d22fc86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juancarlospaco @ThomasTJdev @joachimschmidt557