Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobx: Upgrade urijs typings #4116

Closed
na9da opened this issue Mar 3, 2020 · 0 comments · Fixed by #7435
Closed

Mobx: Upgrade urijs typings #4116

na9da opened this issue Mar 3, 2020 · 0 comments · Fixed by #7435
Labels
Low priority Version 8 formerly MobX

Comments

@na9da
Copy link
Collaborator

na9da commented Mar 3, 2020

urijs typings have changed and our code is not compatible with it. Had to temporarily fix on 1.19.1 so that our builds pass. This ticket is to upgrade urijs to the latest version.
@na9da na9da mentioned this issue Mar 3, 2020
Merged
@meh9 meh9 added the Version 8 formerly MobX label Mar 4, 2020
pjonsson added a commit to pjonsson/terriajs that referenced this issue Jan 1, 2025
@pjonsson
Update types/urijs
a749cb8 
Update types/urijs to the latest
version and update the names for
the types in the code.

Also remove lib/ThirdParty/urijs
and put in ts-expect-error in
the two places that accesses
the expression directly.

Fixes TerriaJS#4116
@pjonsson pjonsson mentioned this issue Jan 1, 2025
Merged
4 tasks
pjonsson added a commit to pjonsson/terriajs that referenced this issue Jan 2, 2025
@pjonsson
Update types/urijs
d24497e 
Update types/urijs to the latest
version and update the names for
the types in the code.

Also change the code that previously
accessed the internal "expression"
of URITemplate to remember the URL
instead and remove those accesses.

Fixes TerriaJS#4116
pjonsson added a commit to pjonsson/terriajs that referenced this issue Jan 2, 2025
@pjonsson
Update types/urijs
ef48dd5 
Update types/urijs to the latest
version and update the names for
the types in the code.

Also change the code that previously
accessed the internal "expression"
of URITemplate to remember the URL
instead and remove those accesses.

Fixes TerriaJS#4116
pjonsson added a commit to pjonsson/terriajs that referenced this issue Jan 15, 2025
@pjonsson
Update types/urijs
100bf7b 
Update types/urijs to the latest
version and update the names for
the types in the code.

Also change the code that previously
accessed the internal "expression"
of URITemplate to remember the URL
instead and remove those accesses.

Fixes TerriaJS#4116
pjonsson added a commit to pjonsson/terriajs that referenced this issue Jan 16, 2025
@pjonsson
Update types/urijs
10f0e43 
Update types/urijs to the latest
version and update the names for
the types in the code.

Also change the code that previously
accessed the internal "expression"
of URITemplate to remember the URL
instead and remove those accesses.

Fixes TerriaJS#4116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low priority Version 8 formerly MobX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update types/urijs pjonsson/terriajs
3 participants
@na9da @meh9 @soyarsauce