-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.8 support for macro code #16
Comments
Related to #1. |
Issues cleanup: 0.15 is probably a long way off; we should actually add 3.8 support earlier. Maybe in a small service release after 0.14.2? |
The GTS docs have updated to 3.8. |
This is a bug in that until we support |
0.14.3 is becoming such a big update already, maybe it's better to add Python 3.8 support in the next release. |
Also consider if we need to do something with |
While at it, we should add support also for Python 3.9. The |
Done. Now just need to port the macro code to |
In the Python 3.8 AST, all constants are now represented by the
ast.Constant
node type.Thus to support 3.8 and later properly, we will need to update any macro code that deals with
Num
,Str
,NameConstant
.Maybe in 0.15, move these into
syntax.astcompat
, and start acceptingConstant
nodes as an alternative.There are not many use sites, so it's probably not worth building an abstraction for this.
The text was updated successfully, but these errors were encountered: