Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate watch history to Jetpack Compose #11947

Open
wants to merge 17 commits into
base: refactor
Choose a base branch
from

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Rewrite the watch history UI using Jetpack Compose. As part of this change, the ItemList composable was refactored to use separate data classes, in order to further decouple it from the information provided by the extractor and make it more easily reusable.
  • Clean up unused methods in StreamHistoryDAO.
  • Reimplement the watch history retrieval from the Room database using AndroidX Paging for improved efficiency, as it supports pagination.
  • Add stream card and grid composables.
  • Update several relevant dependencies, including the Compose BOM version.

Before/After Screenshots/Screen Record

  • Before:

Screenshot_20250121-064842

  • After:

Screenshot_20250121-063312

Screenshot_20250121-063321

Screen_recording_20250121_063348.mp4

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jan 21, 2025
@ShareASmile ShareASmile added history Anything to do with previously watched stuff rewrite Issues and PRs related to rewrite GUI Issue is related to the graphical user interface dependency Issues and PRs related to dependencies labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies GUI Issue is related to the graphical user interface history Anything to do with previously watched stuff rewrite Issues and PRs related to rewrite size/giant PRs with more than 750 changed lines
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants