Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content model of <person> et al permits <ptr> but not <ref> #2651

Open
lb42 opened this issue Jan 10, 2025 · 1 comment
Open

content model of <person> et al permits <ptr> but not <ref> #2651

lb42 opened this issue Jan 10, 2025 · 1 comment

Comments

@lb42
Copy link
Member

lb42 commented Jan 10, 2025

The content model of <person> and (presumably other ography-elements tho I have not checked) is weird. A bit less weird than it used to be, but still weird. Amongst other things, it permits one or more <ptr> elements as direct child, but not (directly) <ref>. Since the former is a degenerate (empty) case of the latter, this really doesn't make any sense. How is a chap supposed to add useful links pointing (for example) to discussions of a Person elsewhere? Do I really have to wrap each <ref> inside a <bibl>, just because I want to say something about the URL I am supplying, whereas Mr Slapdash who is going to give you just the URL and nothing more is allowed to get away with a bare <ptr>?

@ebeshero
Copy link
Member

@lb42 Reviewing this quickly, I agree that's rather oddly specific to require a <ptr> and not to allow <ref>. I don't think we had any good reason not to make the last part of the content model point to a class rather than just this element?

My recommendation is that we:

  • replace the elementRef for <ptr> in the content model of <person> with the a classRef for model.ptrLike, since that would allow <listRef>, <ptr>, and <ref>,
  • check the other "ography" elements to see how we've defined those and update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants