Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

trishaoconnor · 2024-12-10T21:27:11Z

Replaced 'break' with 'beginning' for page|line|column|gathering in the following files from the Guidelines and Specs:

-     page beginning (<pb>)
-     column beginning (<cb>)
-     att.breaking
-     parameter (<param>)
-     model (<model>)
-     att.edition
-     att.milestoneUnit
-     WD Non Standard Characters
-     SG Gentle Introduction
-     PH Primary Sources
-     NH Non Hierarchical
-     HD Header
-     FT Tables Formulae Graphics
-     DS Default Text Structure
-     DI Print Dictionaries
-     CO Core Elements
-     CH Language Character Sets

There were no mentions of 'break' in the prose of <gb> but I deleted an superfluous space in the prose

The requested changes to <lb> are addressed in PR #2633.

ebeshero · 2025-01-12T00:24:19Z

@sydb Might as well have a look at this while you're at it?

sydb

The majority of my suggestions for change, here, are underpinned by my strong distaste for using the noun “beginning” unless it is being used to gloss an element itself or very specifically about the beginning of a feature. Others may disagree.

sydb · 2025-01-12T21:16:36Z

P5/Source/Guidelines/en/CH-LanguagesCharacterSets.xml

@@ -426,7 +426,7 @@ dates, and predefined value lists.</note></p></div>
   individual characters, the overall typesetting process also
   follows specific rules of how to calculate the distance between
   characters, how much whitespace occurs between words, at which
-   points line breaks might occur and so forth.  </p>


This use of the term has nothing to do with our <lb> element, and perhaps should just be left as “break”.

How would you feel about rewriting the above without "break" and to avoid repetition of "occurs" and "occur":

"... at which points new lines might begin and so forth"

sydb · 2025-01-12T21:20:31Z

P5/Source/Guidelines/en/CO-CoreElements.xml

@@ -329,7 +329,7 @@ problem for text encoders. Suppose, for example, that we wish to
 investigate a diachronic English corpus for occurrences of
 <mentioned>tea-pot</mentioned> and <mentioned>teapot</mentioned>, to
 find evidence for the point at which this compound becomes
-lexicalized. Any case where the word is hyphenated across a linebreak,


This use of the term has nothing to do with our <lb> element, and perhaps should just be left as “line break”. (Note the space — 18 of the 25 occurences of "line.?break" in the Guidelines have a space. (One has a hyphen, and six have the single word version.)

sydb · 2025-01-12T21:22:18Z

P5/Source/Guidelines/en/CO-CoreElements.xml

@@ -381,11 +381,11 @@ whitespace. </p>

 <p> The <gi>lb</gi>, <gi>pb</gi>, and <gi>cb</gi> elements are notable
 exceptions to this general rule, since their function is precisely to
-represent (or replace) line, page, or column breaks, which, as noted
+represent (or replace) line, page, or column beginnings, which, as noted
 above, are generally considered to be equivalent to whitespace. These
 elements provide a more reliable way of preserving the lineation,
 pagination, etc of a source document, since the encoder should not


Missing period after “etc”. (I know that has nothing to do with the changes @trishaoconnor is making, but since I noticed it …)

sydb · 2025-01-12T21:24:05Z

P5/Source/Guidelines/en/CO-CoreElements.xml

@@ -3492,11 +3492,11 @@ section <ptr target="#CORS6"/> and in section <ptr target="#SACR"/>.
 <p>When a text has no pre-existing associated reference system of any
 kind, these Guidelines recommend as a minimum that at least the page
 boundaries of the source text be marked using one of the methods
-outlined in this section.  Retaining page breaks in the markup is also
+outlined in this section.  Retaining page beginnings in the markup is also


I would use “boundaries” as opposed to either “breaks” or “beginnings”.

sydb · 2025-01-12T21:24:38Z

P5/Source/Guidelines/en/CO-CoreElements.xml

 recommended for texts which have a detailed reference system of their
-own. Line breaks in prose texts may be, but need not be, tagged.<note place="bottom">Many encoders find it convenient to retain the line


I would leave as “break”.

sydb · 2025-01-12T23:57:14Z

P5/Source/Guidelines/en/WD-NonStandardCharacters.xml

@@ -1250,11 +1250,11 @@ precinct at Dodona. (L.H. Jeffery Archive)</head>
 is reversed, and so is their individual orientation (in fact, we see them
 <soCalled>from the back</soCalled>, as it were). <gi>seg</gi> elements
 have been used here because these are clearly not <soCalled>lines</soCalled>
- in the sense of poetic lines; the text is continuous prose, and linebreaks
+    in the sense of poetic lines; the text is continuous prose, and line beginnings


Perhaps “… continuous prose, and division into separate lines is incidental.” or some such?

Updated to “… continuous prose, and the division into separate lines is incidental.”

sydb · 2025-01-13T00:03:07Z

P5/Source/Guidelines/en/WD-NonStandardCharacters.xml

 are incidental.</p>

   <p>There are obviously some unsatisfactory aspects of this manner of encoding
- boustrophedon. In the inscription above, some words run across linebreaks,
+ boustrophedon. In the inscription above, some words run across line beginnings,


I think “some words are split across two lines,” would be better.

Agreed. I've applied the above change.

sydb · 2025-01-13T00:06:37Z

P5/Source/Specs/att.breaking.xml

@@ -46,7 +46,7 @@ of any adjacent whitespace</desc>
      </valList>
      <exemplum xml:lang="en">
        <p>In the following lines from the <title level="a">Dream of the Rood</title>, 
-      linebreaks occur in the middle of the words <mentioned>lāðost</mentioned> 
+      line beginnings occur in the middle of the words <mentioned>lāðost</mentioned> 


I think something like

<p>In the following lines from the <title level="a">Dream of the Rood</title>, the words <mentioned>lāðost</mentioned> and <mentioned>reord-berendum</mentioned> each start on one line and continue on the next.</p>

would be better.

Thank you very much, I've updated the file with your recommended changes.

sydb · 2025-01-13T00:08:50Z

P5/Source/Specs/model.xml

@@ -100,7 +100,7 @@
          </paramList>
        </valItem>
        <valItem ident="break">
-          <desc versionDate="2015-08-21" xml:lang="en">create a line, column, or page break


IMOm, this should be left “break”.

sydb · 2025-01-13T00:11:03Z

P5/Source/Specs/param.xml

@@ -72,7 +72,7 @@
        </valItem>
        <valItem ident="type">
          <desc versionDate="2017-05-11" xml:lang="en">a parameter of this name can be used to
-            categorize the specified behaviour in any way; for example the kind of break (when used


I think this should remain “break”.

martindholmes · 2025-01-13T23:07:22Z

@trishaoconnor Just letting you know I've just cherry-picked a single-character commit fix from dev into this branch just to make sure it didn't cause any issues. It was a typo in the boustrophedon section of WD-NonStandardCharacters.xml which just needed an added s, found by @sydb. Doesn't affect any of the other stuff in your branch.

trishaoconnor · 2025-01-16T12:38:21Z

Thank you very much @sydb for your thorough review and thank you too @martindholmes for fixing that typo and merging it to the PR.

I appreciate your point @sydb and thank you very much for highlighting the passages where "beginning" isn't an appropriate substitution for "break". I confess that I still have a preference for using "beginning" instead of "break" and would be in favour of rewriting these passages along similar lines to the example that you supplied above:

<p>In the following lines from the <title level="a">Dream of the Rood</title>, the words <mentioned>lāðost</mentioned> and <mentioned>reord-berendum</mentioned> each start on one line and continue on the next.</p>

Of course, if the general consensus is to revert to "break" instead, I'll happily do so.

trishaoconnor added 5 commits December 10, 2024 20:47

replaced break with beginning for pb and cb

ea3d132

Replace breaks with beginnings for att.breaking example

9aaa9eb

Replace break with beginning in param

69b6f21

Replace break with beginning

77bf022

Replace break with beginning

68d7f10

trishaoconnor requested a review from torstenroeder December 10, 2024 21:27

trishaoconnor assigned GusRiva Dec 10, 2024

trishaoconnor added the Status: Go label Dec 10, 2024

trishaoconnor added this to the Guidelines 4.9.0 milestone Dec 10, 2024

trishaoconnor mentioned this pull request Dec 10, 2024

replace * break with * beginning #2603

Open

4 tasks

GusRiva linked an issue Dec 14, 2024 that may be closed by this pull request

replace * break with * beginning #2603

Open

4 tasks

ebeshero requested a review from sydb January 12, 2025 00:23

ebeshero self-assigned this Jan 12, 2025

sydb requested changes Jan 13, 2025

View reviewed changes

Fix missing s per @sydb.

fdb054d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

trishaoconnor commented Dec 10, 2024 •

edited

Loading

ebeshero commented Jan 12, 2025

sydb left a comment

sydb Jan 12, 2025

trishaoconnor Jan 16, 2025 •

edited

Loading

sydb Jan 12, 2025

sydb Jan 12, 2025

sydb Jan 12, 2025

sydb Jan 12, 2025

sydb Jan 12, 2025

trishaoconnor Jan 16, 2025

sydb Jan 13, 2025

trishaoconnor Jan 16, 2025

sydb Jan 13, 2025

trishaoconnor Jan 16, 2025

sydb Jan 13, 2025

sydb Jan 13, 2025

martindholmes commented Jan 13, 2025

trishaoconnor commented Jan 16, 2025

		recommended for texts which have a detailed reference system of their
		own. Line breaks in prose texts may be, but need not be, tagged.<note place="bottom">Many encoders find it convenient to retain the line

Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

Are you sure you want to change the base?

Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs #2634

Conversation

trishaoconnor commented Dec 10, 2024 • edited Loading

ebeshero commented Jan 12, 2025

sydb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trishaoconnor Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martindholmes commented Jan 13, 2025

trishaoconnor commented Jan 16, 2025

trishaoconnor commented Dec 10, 2024 •

edited

Loading

trishaoconnor Jan 16, 2025 •

edited

Loading