-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove generic reactions #219
Comments
@BenjaSanchez Hi Ben, I agree that r_4308 should be removed. |
Other instances of generic reactions: Generic lipid
R-group
Generic protein
Generic sulfur
Various
|
Some generic reactions can be changed into more detailed reactions if we know the detailed functions of the enzymes. So be careful when we delete some generic reactions. |
Good point @hongzhonglu, but I'd argue that protein-modifying enzymes are still outside the scope of a purely metabolic model, which is what yeast-GEM represents. So should we then remove the reactions labelled as Regardless what we decide for the protein-modifying reactions, I think @hongzhonglu makes a fair argument that future knowledge might allow to curate these generic reactions to specific metabolites. In the meanwhile: would it be better to block these reactions (UB and LB = 0), to prevent any possibility of them being involved in some unrealistic loops? For instance
|
For now, blocking these reactions sounds like a good plan to me, maybe also mentioning in the corresponding notes the reason why? |
Description of the issue:
Reaction
r_4308
uses a genericphospholipid
species, not specifying which type of phospholipid it is. As this creates confusion with the rest of the model, which has very specific details for each lipid, e.g.1-phosphatidyl-1D-myo-inositol (1-16:1, 2-16:1)
, I would suggest removing that reaction until it can be formulated with more precise species. In any case, the reaction is blocked and bothphospholipid
species in it are dead-ends as they only appear in this reaction.@hongzhonglu what do you think?
I hereby confirm that I have:
master
branch of the repositoryThe text was updated successfully, but these errors were encountered: