Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add maximum skill tier achieved to lifetime stats #168

Open
cklugewicz opened this issue May 21, 2017 · 1 comment
Open
Labels

Comments

@cklugewicz
Copy link

I believe that adding maximum visual skill tier achieved (both lifetime and for the current season) to the stats available from the /players endpoint would be extremely helpful. For the most utility, the maximum VST should be expressed as a point value, not simply as one of the 30 named skill tiers.

As an example of the players object with the proposed fields added:

{
      "type": "player",
      "id": "eb9063bc-129c-11e5-b365-06eb725f8a76",
      "attributes": {
        "createdAt": "2017-05-21T13:26:35Z",
        "name": "hazeleyes",
        "shardId": "na",
        "stats": {
          "karmaLevel": 2,
          "level": 30,
          "lifetimeGold": 14740.6650390625,
          "lossStreak": 0,
          "played": 3087,
          "played_ranked": 1562,
          "skillTier": 11,
          "maxLifetimeVST": 1465,
          "maxSeasonVST": 1338,
          "winStreak": 0,
          "wins": 1585,
          "xp": 175450
        },
        "titleId": "semc-vainglory"
      },
      "relationships": {
        "assets": {
          "data": []
        }
      }
    }
  ],
  "links": {
    "self": "https://api.dc01.gamelockerapp.com/shards/na/players"
  },
  "meta": {}
}

It has been requested separately to change the "skillTier" value above to the actual points value, but I haven't included that above, even though I agree with that proposal also.

@svperfecta
Copy link
Contributor

@cklugewicz So wondering - If you looked at player (soon to be participant per #145 ) over time, you'd be able to derive max skill tier right? I believe this is available (though it might take a bit of work). It's not available over lifetime, but really this season is what's relevant (changes to meta over time and all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants