Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix promote ip string as double type in csv files() #55173

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[BugFix] Fix promote ip string as double type in csv files() #55173

merged 1 commit into from
Jan 17, 2025
+51 −0

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jan 16, 2025

Why I'm doing:

What I'm doing:

Fixes #55172

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@wyb wyb requested a review from a team as a code owner January 16, 2025 16:36
@mergify mergify bot assigned wyb Jan 16, 2025
@wyb wyb force-pushed the files_csv_double branch from 3aab5a2 to 9e5d61f Compare January 16, 2025 16:40
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/string_parser.hpp 3 3 100.00% []

@wyb wyb merged commit fe95ca6 into StarRocks:main Jan 17, 2025
45 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 17, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@wyb @mergify
[BugFix] Fix promote ip string as double type in csv files() (#55173)
8d8a4ff 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit fe95ca6)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@wyb @mergify
[BugFix] Fix promote ip string as double type in csv files() (#55173)
263a401 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit fe95ca6)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
18 tasks
@wyb
Copy link
Contributor Author

wyb commented Jan 17, 2025

https://github.com/Mergifyio backport branch-3.4.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025 •
edited
Loading

backport branch-3.4.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@wyb @mergify
[BugFix] Fix promote ip string as double type in csv files() (#55173)
b52ba95 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit fe95ca6)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 17, 2025
@mergify @wyb
[BugFix] Fix promote ip string as double type in csv files() (backport …
ca0ac2e 
…#55173) (#55184)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 17, 2025
@mergify @wyb
[BugFix] Fix promote ip string as double type in csv files() (backport …
0398263 
…#55173) (#55186)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 17, 2025
@mergify @wyb
[BugFix] Fix promote ip string as double type in csv files() (backport …
4cd19c7 
…#55173) (#55185)

Co-authored-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohaha luohaha luohaha approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@wyb wyb

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] promote ip string as double type in csv files()
3 participants
@wyb @kevincai @luohaha