Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double negations to check for cancellation #83

Open
LeonNissen opened this issue Dec 18, 2024 · 0 comments
Open

Avoid double negations to check for cancellation #83

LeonNissen opened this issue Dec 18, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@LeonNissen
Copy link
Contributor

LeonNissen commented Dec 18, 2024 •
edited
Loading

Refactor the check for cancellation checkCancellation so that we don't have a double negation (guard & !), throughout the whole framework.

I usually try to void double negations since they make the code harder to read. Instead we can use if.

Originally posted by @jdisho in #81 (comment)
@LeonNissen LeonNissen added the good first issue Good for newcomers label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeonNissen