-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: add format process on generate command #1112
Comments
Thanks for adding the issue @akifarhan |
@akifarhan @FilledStacks I'm not sure of this feature, generated code is not intended to be read and, because of that, I don't see why it should respect the format style of the project. The generated code could be obfuscated, which should not be a problem for us. It is just an opinion, what do you think of this? |
Thank you for the feedback @ferrarafer . I understand that generated code is primarily intended for functionality rather than readability. However, I have some concerns regarding the current behaviour:
I believe integrating a formatting step into the |
@akifarhan I will tackle this improvement next week. |
Thank you @ferrarafer ! Appreciate it. I would like to contribute and I've already created a PR but am having difficulties testing it locally. I've tried this: But received this error whenever I tried to run stacked commands. I appreciate it if you could help me to test it locally. |
Hi @akifarhan, I just saw the message and already pushed the PR. To test the changes locally I usually do the following: dart bin/stacked.dart generate Take into account the example above suppose you are at the root of the project of the |
@akifarhan this has been merged into the cli |
Is your feature request related to a problem? Please describe.
No response
Describe the solution you would like
Introduce a formatting process for the
stacked generate
command to ensure the generated files adhere to the user-defined line length. This enhancement aligns the behaviour of the stacked generate command with the stacked create command, which already formats files according to the specified line length.Additional Context
Related links:
PR
Discussion
The text was updated successfully, but these errors were encountered: