New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 0.6.2? #43

Open

chrispbailey opened this issue Dec 19, 2018 · 1 comment

chrispbailey commented Dec 19, 2018

The move away from env.clone on this line:https://github.com/SortableJS/angular-legacy-sortablejs/compare/8e2f1c97897da91ab373537b47551cabfab2e078..master#diff-fd07c4295c44d1bcf1aaf3d5862c0afbL115 caused an issue dragging and dropping between multiple sortable lists. The source list's order gets shuffled around (see attached video).

chrispbailey changed the title ~~Regression in 0.6.2~~ Regression in 0.6.2?

Contributor

samjacobclift commented Dec 20, 2018

hmm someone did request this to be changed to that, is the issue caused because the check fails or because it passes?

perhaps we could change it to an or

if ((evt.clone) || (Sortable.active && Sortable.active.lastPullMode === 'clone')) {

filipkis mentioned this issue

Error when dropping an item with nested list into a another item with nested list #44

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment